Bladeren bron

DRY email logic

Andrew Kane 9 jaren geleden
bovenliggende
commit
68d2bab829
3 gewijzigde bestanden met toevoegingen van 6 en 2 verwijderingen
  1. 4 0
      app/models/blazer/check.rb
  2. 1 1
      app/views/blazer/checks/index.html.erb
  3. 1 1
      lib/blazer.rb

+ 4 - 0
app/models/blazer/check.rb

@@ -4,6 +4,10 @@ module Blazer
 
     validates :blazer_query_id, presence: true
 
+    def split_emails
+      emails.to_s.split(",").map(&:strip)
+    end
+
     def update_state(rows, error)
       self.state =
         if error

+ 1 - 1
app/views/blazer/checks/index.html.erb

@@ -26,7 +26,7 @@
         </td>
         <td>
           <ul class="list-unstyled" style="margin-bottom: 0;">
-            <% check.emails.to_s.split(",").each do |email| %>
+            <% check.split_emails.each do |email| %>
               <li><%= email %></li>
             <% end %>
           </ul>

+ 1 - 1
lib/blazer.rb

@@ -80,7 +80,7 @@ module Blazer
   def self.send_failing_checks
     emails = {}
     Blazer::Check.includes(:blazer_query).where(state: %w[failing error]).find_each do |check|
-      check.emails.to_s.split(",").map(&:strip).each do |email|
+      check.split_emails.each do |email|
         (emails[email] ||= []) << check
       end
     end