session_test.rb 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516
  1. require 'test_helper'
  2. require 'timecop'
  3. class SessionTest < Test::Unit::TestCase
  4. def setup
  5. super
  6. ShopifyAPI::Session.secret = 'secret'
  7. end
  8. test "not be valid without a url" do
  9. session = ShopifyAPI::Session.new(domain: nil, token: "any-token", api_version: any_api_version)
  10. assert_not session.valid?
  11. end
  12. test "not be valid without token" do
  13. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: any_api_version)
  14. assert_not session.valid?
  15. end
  16. test "not be valid without an api version" do
  17. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: "any-token", api_version: nil)
  18. assert_not session.valid?
  19. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: "any-token", api_version: ShopifyAPI::ApiVersion::NullVersion)
  20. assert_not session.valid?
  21. end
  22. test "be valid with any token, any url and version" do
  23. session = ShopifyAPI::Session.new(
  24. domain: "testshop.myshopify.com",
  25. token: "any-token",
  26. api_version: any_api_version
  27. )
  28. assert session.valid?
  29. end
  30. test "not raise error without params" do
  31. assert_nothing_raised do
  32. ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: "any-token", api_version: any_api_version)
  33. end
  34. end
  35. test "ignore everything but the subdomain in the shop" do
  36. assert_equal(
  37. "https://testshop.myshopify.com",
  38. ShopifyAPI::Session.new(
  39. domain: "http://user:pass@testshop.notshopify.net/path",
  40. token: "any-token",
  41. api_version: any_api_version
  42. ).site
  43. )
  44. end
  45. test "append the myshopify domain if not given" do
  46. assert_equal(
  47. "https://testshop.myshopify.com",
  48. ShopifyAPI::Session.new(domain: "testshop", token: "any-token", api_version: any_api_version).site
  49. )
  50. end
  51. test "not raise error without params" do
  52. assert_nothing_raised do
  53. ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: "any-token", api_version: any_api_version)
  54. end
  55. end
  56. test "raise error if params passed but signature omitted" do
  57. assert_raises(ShopifyAPI::ValidationException) do
  58. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: any_api_version)
  59. session.request_token({'code' => 'any-code'})
  60. end
  61. end
  62. test "setup api_key and secret for all sessions" do
  63. ShopifyAPI::Session.setup(:api_key => "My test key", :secret => "My test secret")
  64. assert_equal "My test key", ShopifyAPI::Session.api_key
  65. assert_equal "My test secret", ShopifyAPI::Session.secret
  66. end
  67. test "#temp reset ShopifyAPI::Base values to original value" do
  68. session1 = ShopifyAPI::Session.new(domain: 'fakeshop.myshopify.com', token: 'token1', api_version: '2019-01')
  69. ShopifyAPI::Base.user = 'foo'
  70. ShopifyAPI::Base.password = 'bar'
  71. ShopifyAPI::Base.activate_session(session1)
  72. ShopifyAPI::Session.temp(domain: "testshop.myshopify.com", token: "any-token", api_version: :unstable) do
  73. @assigned_site = ShopifyAPI::Base.site
  74. @assigned_version = ShopifyAPI::Base.api_version
  75. @assigned_user = ShopifyAPI::Base.user
  76. @assigned_password = ShopifyAPI::Base.password
  77. end
  78. assert_equal('https://testshop.myshopify.com', @assigned_site.to_s)
  79. assert_equal('https://fakeshop.myshopify.com', ShopifyAPI::Base.site.to_s)
  80. assert_equal(ShopifyAPI::ApiVersion.new(handle: :unstable), @assigned_version)
  81. assert_equal(ShopifyAPI::ApiVersion.new(handle: '2019-01'), ShopifyAPI::Base.api_version)
  82. assert_nil(@assigned_user)
  83. assert_equal('foo', ShopifyAPI::Base.user)
  84. assert_nil(@assigned_password)
  85. assert_equal('bar', ShopifyAPI::Base.password)
  86. end
  87. test "#temp does not use basic auth values from Base.site" do
  88. ShopifyAPI::Base.site = 'https://user:pass@fakeshop.myshopify.com'
  89. ShopifyAPI::Session.temp(domain: "testshop.myshopify.com", token: "any-token", api_version: :unstable) do
  90. @assigned_site = ShopifyAPI::Base.site
  91. @assigned_user = ShopifyAPI::Base.user
  92. @assigned_password = ShopifyAPI::Base.password
  93. end
  94. assert_equal('https://testshop.myshopify.com', @assigned_site.to_s)
  95. assert_equal('https://fakeshop.myshopify.com', ShopifyAPI::Base.site.to_s)
  96. assert_nil(@assigned_user)
  97. assert_equal('user', ShopifyAPI::Base.user)
  98. assert_nil(@assigned_password)
  99. assert_equal('pass', ShopifyAPI::Base.password)
  100. end
  101. test "#with_session activates the session for the duration of the block" do
  102. session1 = ShopifyAPI::Session.new(domain: 'fakeshop.myshopify.com', token: 'token1', api_version: '2019-01')
  103. ShopifyAPI::Base.activate_session(session1)
  104. other_session = ShopifyAPI::Session.new(
  105. domain: "testshop.myshopify.com",
  106. token: "any-token",
  107. api_version: :unstable
  108. )
  109. ShopifyAPI::Session.with_session(other_session) do
  110. @assigned_site = ShopifyAPI::Base.site
  111. @assigned_version = ShopifyAPI::Base.api_version
  112. end
  113. assert_equal('https://testshop.myshopify.com', @assigned_site.to_s)
  114. assert_equal('https://fakeshop.myshopify.com', ShopifyAPI::Base.site.to_s)
  115. assert_equal(ShopifyAPI::ApiVersion.new(handle: :unstable), @assigned_version)
  116. assert_equal(ShopifyAPI::ApiVersion.new(handle: '2019-01'), ShopifyAPI::Base.api_version)
  117. end
  118. test "#with_session resets the activated session even if there an exception during the block" do
  119. session1 = ShopifyAPI::Session.new(domain: 'fakeshop.myshopify.com', token: 'token1', api_version: '2019-01')
  120. ShopifyAPI::Base.activate_session(session1)
  121. other_session = ShopifyAPI::Session.new(
  122. domain: "testshop.myshopify.com",
  123. token: "any-token",
  124. api_version: :unstable
  125. )
  126. assert_raises StandardError do
  127. ShopifyAPI::Session.with_session(other_session) { raise StandardError, "" }
  128. end
  129. assert_equal('https://fakeshop.myshopify.com', ShopifyAPI::Base.site.to_s)
  130. assert_equal(ShopifyAPI::ApiVersion.new(handle: '2019-01'), ShopifyAPI::Base.api_version)
  131. end
  132. test "#with_version will adjust the actvated api version for the duration of the block" do
  133. session1 = ShopifyAPI::Session.new(domain: 'fakeshop.myshopify.com', token: 'token1', api_version: '2019-01')
  134. ShopifyAPI::Base.activate_session(session1)
  135. ShopifyAPI::Session.with_version(:unstable) do
  136. @assigned_site = ShopifyAPI::Base.site
  137. @assigned_version = ShopifyAPI::Base.api_version
  138. end
  139. assert_equal('https://fakeshop.myshopify.com', @assigned_site.to_s)
  140. assert_equal('https://fakeshop.myshopify.com', ShopifyAPI::Base.site.to_s)
  141. assert_equal(ShopifyAPI::ApiVersion.new(handle: :unstable), @assigned_version)
  142. assert_equal(ShopifyAPI::ApiVersion.new(handle: '2019-01'), ShopifyAPI::Base.api_version)
  143. end
  144. test "create_permission_url requires redirect_uri" do
  145. ShopifyAPI::Session.setup(api_key: "My_test_key", secret: "My test secret")
  146. session = ShopifyAPI::Session.new(
  147. domain: 'http://localhost.myshopify.com',
  148. token: 'any-token',
  149. api_version: any_api_version
  150. )
  151. scope = ["write_products"]
  152. assert_raises(ArgumentError) do
  153. session.create_permission_url(scope)
  154. end
  155. end
  156. test "create_permission_url returns correct url with single scope and redirect uri" do
  157. ShopifyAPI::Session.setup(api_key: "My_test_key", secret: "My test secret")
  158. session = ShopifyAPI::Session.new(
  159. domain: 'http://localhost.myshopify.com',
  160. token: 'any-token',
  161. api_version: any_api_version
  162. )
  163. scope = ["write_products"]
  164. permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com")
  165. assert_equal "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&scope=write_products&redirect_uri=http://my_redirect_uri.com", permission_url
  166. end
  167. test "create_permission_url returns correct url with dual scope" do
  168. ShopifyAPI::Session.setup(api_key: "My_test_key", secret: "My test secret")
  169. session = ShopifyAPI::Session.new(
  170. domain: 'http://localhost.myshopify.com',
  171. token: 'any-token',
  172. api_version: any_api_version
  173. )
  174. scope = ["write_products","write_customers"]
  175. permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com")
  176. assert_equal "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&scope=write_products,write_customers&redirect_uri=http://my_redirect_uri.com", permission_url
  177. end
  178. test "create_permission_url returns correct url with no scope" do
  179. ShopifyAPI::Session.setup(api_key: "My_test_key", secret: "My test secret")
  180. session = ShopifyAPI::Session.new(
  181. domain: 'http://localhost.myshopify.com',
  182. token: 'any-token',
  183. api_version: any_api_version
  184. )
  185. scope = []
  186. permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com")
  187. assert_equal "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&scope=&redirect_uri=http://my_redirect_uri.com", permission_url
  188. end
  189. test "create_permission_url returns correct url with state" do
  190. ShopifyAPI::Session.setup(api_key: "My_test_key", secret: "My test secret")
  191. session = ShopifyAPI::Session.new(
  192. domain: 'http://localhost.myshopify.com',
  193. token: 'any-token',
  194. api_version: any_api_version
  195. )
  196. scope = []
  197. permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com", state: "My nonce")
  198. assert_equal "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&scope=&redirect_uri=http://my_redirect_uri.com&state=My%20nonce", permission_url
  199. end
  200. test "raise exception if code invalid in request token" do
  201. ShopifyAPI::Session.setup(:api_key => "My test key", :secret => "My test secret")
  202. session = ShopifyAPI::Session.new(
  203. domain: 'http://localhost.myshopify.com',
  204. token: nil,
  205. api_version: any_api_version
  206. )
  207. fake(
  208. nil,
  209. url: 'https://localhost.myshopify.com/admin/oauth/access_token',
  210. method: :post,
  211. status: 404,
  212. body: '{"error" : "invalid_request"}'
  213. )
  214. assert_raises(ShopifyAPI::ValidationException) do
  215. session.request_token(code: "bad-code")
  216. end
  217. assert_equal false, session.valid?
  218. end
  219. test "return site for session" do
  220. session = ShopifyAPI::Session.new(
  221. domain: "testshop.myshopify.com",
  222. token: "any-token",
  223. api_version: any_api_version
  224. )
  225. assert_equal "https://testshop.myshopify.com", session.site
  226. end
  227. test "return_token_if_signature_is_valid" do
  228. api_version = any_api_version
  229. fake nil,
  230. url: "https://testshop.myshopify.com/admin/oauth/access_token",
  231. method: :post,
  232. body: '{"access_token":"any-token"}'
  233. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: api_version)
  234. params = { code: 'any-code', timestamp: Time.now }
  235. token = session.request_token(params.merge(hmac: generate_signature(params)))
  236. assert_equal "any-token", token
  237. assert_equal "any-token", session.token
  238. end
  239. test "extra parameters are stored in session" do
  240. api_version = ShopifyAPI::ApiVersion.new(handle: :unstable)
  241. fake nil,
  242. url: "https://testshop.myshopify.com/admin/oauth/access_token",
  243. method: :post,
  244. body: '{"access_token":"any-token","foo":"example"}'
  245. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: api_version)
  246. params = { code: 'any-code', timestamp: Time.now }
  247. assert session.request_token(params.merge(hmac: generate_signature(params)))
  248. assert_equal ({ "foo" => "example" }), session.extra
  249. end
  250. test "expires_in is automatically converted in expires_at" do
  251. api_version = any_api_version
  252. fake nil,
  253. url: "https://testshop.myshopify.com/admin/oauth/access_token",
  254. method: :post,
  255. body: '{"access_token":"any-token","expires_in":86393}'
  256. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: api_version)
  257. Timecop.freeze do
  258. params = { code: 'any-code', timestamp: Time.now }
  259. assert session.request_token(params.merge(hmac: generate_signature(params)))
  260. expires_at = Time.now.utc + 86393
  261. assert_equal ({ "expires_at" => expires_at.to_i }), session.extra
  262. assert session.expires_at.is_a?(Time)
  263. assert_equal expires_at.to_i, session.expires_at.to_i
  264. assert_equal 86393, session.expires_in
  265. assert_equal false, session.expired?
  266. Timecop.travel(session.expires_at) do
  267. assert_equal true, session.expired?
  268. end
  269. end
  270. end
  271. test "raise error if signature does not match expected" do
  272. params = {:code => "any-code", :timestamp => Time.now}
  273. signature = generate_signature(params)
  274. params[:foo] = 'world'
  275. assert_raises(ShopifyAPI::ValidationException) do
  276. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: any_api_version)
  277. session.request_token(params.merge(:hmac => signature))
  278. end
  279. end
  280. test "raise error if timestamp is too old" do
  281. params = {:code => "any-code", :timestamp => Time.now - 2.days}
  282. signature = generate_signature(params)
  283. params[:foo] = 'world'
  284. assert_raises(ShopifyAPI::ValidationException) do
  285. session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: any_api_version)
  286. session.request_token(params.merge(:hmac => signature))
  287. end
  288. end
  289. test "return true when the signature is valid and the keys of params are strings" do
  290. params = { 'code' => 'any-code', 'timestamp' => Time.now }
  291. params[:hmac] = generate_signature(params)
  292. assert_equal true, ShopifyAPI::Session.validate_signature(params)
  293. end
  294. test "return true when validating signature of params with ampersand and equal sign characters" do
  295. ShopifyAPI::Session.secret = 'secret'
  296. params = { 'a' => '1&b=2', 'c=3&d' => '4' }
  297. to_sign = 'a=1%26b=2&c%3D3%26d=4'
  298. params[:hmac] = generate_signature(to_sign)
  299. assert_equal true, ShopifyAPI::Session.validate_signature(params)
  300. end
  301. test "return true when validating signature of params with percent sign characters" do
  302. ShopifyAPI::Session.secret = 'secret'
  303. params = { 'a%3D1%26b' => '2%26c%3D3' }
  304. to_sign = 'a%253D1%2526b=2%2526c%253D3'
  305. params[:hmac] = generate_signature(to_sign)
  306. assert_equal true, ShopifyAPI::Session.validate_signature(params)
  307. end
  308. test "url is aliased to domain to minimize the upgrade changes" do
  309. session = ShopifyAPI::Session.new(
  310. domain: "http://testshop.myshopify.com",
  311. token: "any-token",
  312. api_version: any_api_version
  313. )
  314. assert_equal('testshop.myshopify.com', session.url)
  315. end
  316. test "#hash returns the same value for equal Sessions" do
  317. session = ShopifyAPI::Session.new(
  318. domain: "http://testshop.myshopify.com",
  319. token: "any-token",
  320. api_version: '2019-01',
  321. extra: { foo: "bar" }
  322. )
  323. other_session = ShopifyAPI::Session.new(
  324. domain: "http://testshop.myshopify.com",
  325. token: "any-token",
  326. api_version: '2019-01',
  327. extra: { foo: "bar" }
  328. )
  329. assert_equal(session.hash, other_session.hash)
  330. end
  331. test "equality verifies domain" do
  332. session = ShopifyAPI::Session.new(
  333. domain: "http://testshop.myshopify.com",
  334. token: "any-token",
  335. api_version: '2019-01',
  336. extra: { foo: "bar" }
  337. )
  338. other_session = ShopifyAPI::Session.new(
  339. domain: "http://testshop.myshopify.com",
  340. token: "any-token",
  341. api_version: '2019-01',
  342. extra: { foo: "bar" }
  343. )
  344. different_session = ShopifyAPI::Session.new(
  345. domain: "http://another_testshop.myshopify.com",
  346. token: "any-token",
  347. api_version: '2019-01',
  348. extra: { foo: "bar" }
  349. )
  350. assert_equal(session, other_session)
  351. refute_equal(session, different_session)
  352. end
  353. test "equality verifies token" do
  354. session = ShopifyAPI::Session.new(
  355. domain: "http://testshop.myshopify.com",
  356. token: "any-token",
  357. api_version: '2019-01',
  358. extra: { foo: "bar" }
  359. )
  360. different_session = ShopifyAPI::Session.new(
  361. domain: "http://testshop.myshopify.com",
  362. token: "very-different-token",
  363. api_version: '2019-01',
  364. extra: { foo: "bar" }
  365. )
  366. refute_equal(session, different_session)
  367. end
  368. test "equality verifies api_version" do
  369. session = ShopifyAPI::Session.new(
  370. domain: "http://testshop.myshopify.com",
  371. token: "any-token",
  372. api_version: '2019-01',
  373. extra: { foo: "bar" }
  374. )
  375. different_session = ShopifyAPI::Session.new(
  376. domain: "http://testshop.myshopify.com",
  377. token: "any-token",
  378. api_version: :unstable,
  379. extra: { foo: "bar" }
  380. )
  381. refute_equal(session, different_session)
  382. end
  383. test "equality verifies extra" do
  384. session = ShopifyAPI::Session.new(
  385. domain: "http://testshop.myshopify.com",
  386. token: "any-token",
  387. api_version: '2019-01',
  388. extra: { foo: "bar" }
  389. )
  390. different_session = ShopifyAPI::Session.new(
  391. domain: "http://testshop.myshopify.com",
  392. token: "any-token",
  393. api_version: '2019-01',
  394. extra: { bar: "other-bar" }
  395. )
  396. refute_equal(session, different_session)
  397. end
  398. test "equality verifies other is a Session" do
  399. session = ShopifyAPI::Session.new(
  400. domain: "http://testshop.myshopify.com",
  401. token: "any-token",
  402. api_version: '2019-01',
  403. extra: { foo: "bar" }
  404. )
  405. different_session = nil
  406. refute_equal(session, different_session)
  407. end
  408. test "#eql? and #hash are implemented" do
  409. session = ShopifyAPI::Session.new(
  410. domain: "http://testshop.myshopify.com",
  411. token: "any-token",
  412. api_version: '2019-01',
  413. extra: { foo: "bar" }
  414. )
  415. other_session = ShopifyAPI::Session.new(
  416. domain: "http://testshop.myshopify.com",
  417. token: "any-token",
  418. api_version: '2019-01',
  419. extra: { foo: "bar" }
  420. )
  421. different_session = ShopifyAPI::Session.new(
  422. domain: "http://another_testshop.myshopify.com",
  423. token: "any-token",
  424. api_version: '2019-01',
  425. extra: { foo: "bar" }
  426. )
  427. assert_equal([session, different_session], [session, other_session, different_session].uniq)
  428. end
  429. private
  430. def make_sorted_params(params)
  431. params.with_indifferent_access.except(
  432. :signature, :hmac, :action, :controller
  433. ).collect { |k, v| "#{k}=#{v}" }.sort.join('&')
  434. end
  435. def generate_signature(params)
  436. params = make_sorted_params(params) if params.is_a?(Hash)
  437. OpenSSL::HMAC.hexdigest(OpenSSL::Digest::SHA256.new, ShopifyAPI::Session.secret, params)
  438. end
  439. def any_api_version
  440. version_name = ['2019-01', :unstable].sample(1).first
  441. ShopifyAPI::ApiVersion.find_version(version_name)
  442. end
  443. end