Simon Mathieu 6 年之前
父節點
當前提交
ceb226e21d

+ 3 - 1
lib/shopify_api/resources/ping.rb

@@ -1 +1,3 @@
-Dir.glob("#{File.dirname(__FILE__)}/ping/*").each { |file| require(file) }
+# frozen_string_literal: true
+
+Dir.glob("#{File.dirname(__FILE__)}/ping/*").each { |file| require file }

+ 3 - 1
lib/shopify_api/resources/ping/conversation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ShopifyAPI
   module Ping
     class Conversation < Base
@@ -5,7 +7,7 @@ module ShopifyAPI
 
       def send_message(message_attrs)
         message = ShopifyAPI::Ping::Message.new(
-          message_attrs.merge(conversation_id: self.id)
+          message_attrs.merge(conversation_id: id)
         )
 
         message.save

+ 2 - 0
lib/shopify_api/resources/ping/message.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ShopifyAPI
   module Ping
     class Message < Base

+ 3 - 3
test/ping/conversation_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 
 class PingConversationTest < Test::Unit::TestCase
   def test_create_conversation
-    fake "api/ping-api/v1/conversations", :method => :post, :body => load_fixture('ping/conversation')
+    fake "api/ping-api/v1/conversations", method: :post, body: load_fixture('ping/conversation')
 
     conversation = ShopifyAPI::Ping::Conversation.new(
       topic: 'my topic',
@@ -11,7 +11,7 @@ class PingConversationTest < Test::Unit::TestCase
           name: 'foo',
           id: 'test',
           group: 'customer',
-        }
+        },
       ]
     )
 
@@ -21,7 +21,7 @@ class PingConversationTest < Test::Unit::TestCase
   end
 
   def test_send_message
-    fake "api/ping-api/v1/conversations/123/messages", :method => :post, :body => load_fixture('ping/message')
+    fake "api/ping-api/v1/conversations/123/messages", method: :post, body: load_fixture('ping/message')
 
     conversation = ShopifyAPI::Ping::Conversation.new(id: '123')
     message = conversation.send_message(