Переглянути джерело

Create method for creating delivery attributes.

Tieshia Francis 6 роки тому
батько
коміт
8e3a67a191
1 змінених файлів з 10 додано та 9 видалено
  1. 10 9
      lib/shopify_api/resources/ping/conversation.rb

+ 10 - 9
lib/shopify_api/resources/ping/conversation.rb

@@ -16,10 +16,7 @@ module ShopifyAPI
 
       def successful_delivery(message_id:, delivery_timestamp:)
         delivery_details = ShopifyAPI::Ping::DeliveryConfirmationDetails.new(
-          conversation_id: id,
-          message_id: message_id,
-          delivered: true,
-          confirmation_timestamp: delivery_timestamp
+          delivery_attrs(message_id, delivery_timestamp).merge(delivered: true)
         )
         delivery_details.save
         delivery_details
@@ -27,15 +24,19 @@ module ShopifyAPI
 
       def failed_delivery(message_id:, delivery_timestamp:, details:)
         delivery_details = ShopifyAPI::Ping::DeliveryConfirmationDetails.new(
-          conversation_id: id,
-          message_id: message_id,
-          delivered: false,
-          confirmation_timestamp: delivery_timestamp,
-          details: details
+          delivery_attrs(message_id, delivery_timestamp).merge(delivered: false, details: details)
         )
         delivery_details.save
         delivery_details
       end
+
+      def delivery_attrs(message_id, delivery_timestamp)
+        {
+          conversation_id: id,
+          message_id: message_id,
+          confirmation_timestamp: delivery_timestamp,
+        }
+      end
     end
   end
 end