Преглед на файлове

Merge pull request #722 from adfaris/clear-session-should-not-clear-API-version

Update clear_session not to clear the api-version
Tim Anema преди 5 години
родител
ревизия
8b8826f1bb
променени са 2 файла, в които са добавени 16 реда и са изтрити 1 реда
  1. 0 1
      lib/shopify_api/resources/base.rb
  2. 16 0
      test/base_test.rb

+ 0 - 1
lib/shopify_api/resources/base.rb

@@ -53,7 +53,6 @@ module ShopifyAPI
         self.site = nil
         self.password = nil
         self.user = nil
-        self.api_version = nil
         self.headers.delete('X-Shopify-Access-Token')
       end
 

+ 16 - 0
test/base_test.rb

@@ -38,6 +38,22 @@ class BaseTest < Test::Unit::TestCase
     assert_nil ShopifyAPI::Base.site
   end
 
+  # test to  check session reset api version remains the same after session reset
+  test '#clear_session should not change the api_version' do
+    ShopifyAPI::Base.site = "https://zoo:lion@www.zoo.com"
+
+
+    assert_equal "zoo", ShopifyAPI::Base.user
+    assert_equal "lion", ShopifyAPI::Base.password
+
+    ShopifyAPI::Base.clear_session
+
+    assert_nil ShopifyAPI::Base.user
+    assert_nil ShopifyAPI::Base.password
+    assert_nil ShopifyAPI::Base.site
+    assert_equal ShopifyAPI::Base.api_version,@session1.api_version
+  end
+
   test '#clear_session should clear site and headers from Base' do
     ShopifyAPI::Base.activate_session @session1
     ShopifyAPI::Base.clear_session