Merge pull request #787 from Shopify/fix_rubocop_conflicts_2

Fix rubocop conflicts

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-10-15 14:08:35 UTC using RuboCop version 0.93.1.
+# on 2020-10-15 20:32:09 UTC using RuboCop version 0.93.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,7 +14,7 @@ Layout/CaseIndentation:
   Exclude:
     - 'lib/shopify_api/countable.rb'
 
-# Offense count: 8
+# Offense count: 9
 # Cop supports --auto-correct.
 Layout/ClosingParenthesisIndentation:
   Exclude:
@@ -23,6 +23,7 @@ Layout/ClosingParenthesisIndentation:
     - 'test/application_charge_test.rb'
     - 'test/assigned_fulfillment_order_test.rb'
     - 'test/collection_test.rb'
+    - 'test/recurring_application_charge_test.rb'
 
 # Offense count: 6
 # Cop supports --auto-correct.
@@ -106,7 +107,7 @@ Layout/IndentationWidth:
   Exclude:
     - 'test/fulfillment_service_test.rb'
 
-# Offense count: 2
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
@@ -114,6 +115,7 @@ Layout/MultilineMethodCallBraceLayout:
   Exclude:
     - 'lib/shopify_api/resources/product.rb'
     - 'lib/shopify_api/resources/variant.rb'
+    - 'test/fulfillment_order_test.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -127,7 +129,7 @@ Layout/SpaceAfterColon:
   Exclude:
     - 'test/order_test.rb'
 
-# Offense count: 8
+# Offense count: 6
 # Cop supports --auto-correct.
 Layout/SpaceAfterComma:
   Exclude:
@@ -135,7 +137,6 @@ Layout/SpaceAfterComma:
     - 'lib/shopify_api/session.rb'
     - 'test/base_test.rb'
     - 'test/fulfillment_order_test.rb'
-    - 'test/recurring_application_charge_test.rb'
     - 'test/session_test.rb'
 
 # Offense count: 6
@@ -183,12 +184,11 @@ Layout/TrailingEmptyLines:
     - 'lib/shopify_api/resources/cart.rb'
     - 'test/cart_test.rb'
 
-# Offense count: 4
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
-    - 'test/storefront_access_token_test.rb'
     - 'test/user_test.rb'
 
 # Offense count: 1
@@ -203,6 +203,17 @@ Naming/VariableName:
   Exclude:
     - 'lib/shopify_api/resources/fulfillment.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'test/inventory_level_test.rb'
+
 # Offense count: 2
 # Cop supports --auto-correct.
 Style/ColonMethodCall:
@@ -249,7 +260,13 @@ Style/RedundantException:
   Exclude:
     - 'lib/shopify_api/session.rb'
 
-# Offense count: 6
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RedundantParentheses:
+  Exclude:
+    - 'test/session_test.rb'
+
+# Offense count: 5
 # Cop supports --auto-correct.
 Style/RedundantPercentQ:
   Exclude:
@@ -339,10 +356,3 @@ Style/TrailingCommaInHashLiteral:
 Style/TrivialAccessors:
   Exclude:
     - 'lib/shopify_api/graphql.rb'
-
-# Offense count: 86
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 320

Rakefile

@@ -24,10 +24,10 @@ rescue LoadError
   end
 end
 
-task default: [:test, :rubocop, :verify_docs]
+task(default: [:test, :rubocop, :verify_docs])
 
 require 'verify_docs'
-task :verify_docs do
+task(:verify_docs) do
   unless VerifyDocs.call
     abort("\nWARNING: docs/index.md and README.md no longer have identical content. Please correct this.")
   end
@@ -48,7 +48,7 @@ Rake::RDocTask.new do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-task :docker do
+task(:docker) do
   cmd = "docker-compose up -d && docker exec -i -t shopify_api bash"
   exec(cmd, err: File::NULL)
 end

lib/shopify_api/api_version.rb

@@ -54,8 +54,8 @@ module ShopifyAPI
 
       def define_known_versions
         warn(
-          '[DEPRECATED] ShopifyAPI::ApiVersion.define_known_versions is deprecated and will be removed in a future version. ' \
-            'Use `fetch_known_versions` instead.'
+          '[DEPRECATED] ShopifyAPI::ApiVersion.define_known_versions is deprecated and will be ' \
+            'removed in a future version. Use `fetch_known_versions` instead.'
         )
         fetch_known_versions
       end
@@ -70,15 +70,16 @@ module ShopifyAPI
 
       def clear_defined_versions
         warn(
-          '[DEPRECATED] ShopifyAPI::ApiVersion.clear_defined_versions is deprecated and will be removed in a future version. ' \
-            'Use `clear_known_versions` instead.'
+          '[DEPRECATED] ShopifyAPI::ApiVersion.clear_defined_versions is deprecated and will be ' \
+            'removed in a future version. Use `clear_known_versions` instead.'
         )
         clear_known_versions
       end
 
       def latest_stable_version
         warn(
-          '[DEPRECATED] ShopifyAPI::ApiVersion.latest_stable_version is deprecated and will be removed in a future version.'
+          '[DEPRECATED] ShopifyAPI::ApiVersion.latest_stable_version is deprecated and will be ' \
+            'removed in a future version.'
         )
         versions.values.find(&:latest_supported?)
       end

lib/shopify_api/graphql.rb

@@ -30,7 +30,10 @@ module ShopifyAPI
               To dump the schema file, use the `rake shopify_api:graphql:dump` task.
             MSG
           else
-            puts '[WARNING] Client was not pre-initialized. Ensure `ShopifyAPI::GraphQL.initialize_clients` is called during app initialization.'
+            puts(
+              '[WARNING] Client was not pre-initialized. Ensure `ShopifyAPI::GraphQL.initialize_clients` ' \
+                'is called during app initialization.'
+            )
             initialize_clients
             @_client_cache[api_version]
           end
@@ -52,7 +55,8 @@ module ShopifyAPI
             api_version = ShopifyAPI::ApiVersion.new(handle: matches[1])
           else
             if raise_on_invalid_schema
-              raise InvalidSchema, "Invalid schema file name `#{schema_file}`. Does not match format of: `<version>.json`."
+              raise InvalidSchema,
+                "Invalid schema file name `#{schema_file}`. Does not match format of: `<version>.json`."
             else
               next
             end

lib/shopify_api/pagination_link_headers.rb

@@ -18,7 +18,9 @@ module ShopifyAPI
       links = link_header.split(',')
       links.map do |link|
         parts = link.split('; ')
-        raise ShopifyAPI::InvalidPaginationLinksError, "Invalid link header: url and rel expected" unless parts.length == 2
+        unless parts.length == 2
+          raise ShopifyAPI::InvalidPaginationLinksError, "Invalid link header: url and rel expected"
+        end
 
         url = parts[0][/<(.*)>/, 1]
         rel = parts[1][/rel="(.*)"/, 1]&.to_sym

lib/shopify_api/resources/asset.rb

@@ -9,10 +9,10 @@ module ShopifyAPI
   # or assets/bg-body.gif.
   #
   # Initialize with a key:
-  #   asset = ShopifyAPI::Asset.new(:key => 'assets/special.css', :theme_id => 12345)
+  #   asset = ShopifyAPI::Asset.new(key: 'assets/special.css', theme_id: 12345)
   #
   # Find by key:
-  #   asset = ShopifyAPI::Asset.find('assets/image.png', :params => {:theme_id => 12345})
+  #   asset = ShopifyAPI::Asset.find('assets/image.png', params: {theme_id: 12345})
   #
   # Get the text or binary value:
   #   asset.value # decodes from attachment attribute if necessary
@@ -44,7 +44,7 @@ module ShopifyAPI
     end
 
     # find an asset by key:
-    #   ShopifyAPI::Asset.find('layout/theme.liquid', :params => { theme_id: 99 })
+    #   ShopifyAPI::Asset.find('layout/theme.liquid', params: { theme_id: 99 })
     def self.find(*args)
       if args[0].is_a?(Symbol)
         super

lib/shopify_api/resources/base.rb

@@ -67,7 +67,11 @@ module ShopifyAPI
       end
 
       def api_version=(version)
-        self._api_version = ApiVersion::NullVersion.matches?(version) ? ApiVersion::NullVersion : ApiVersion.find_version(version)
+        self._api_version = if ApiVersion::NullVersion.matches?(version)
+          ApiVersion::NullVersion
+        else
+          ApiVersion.find_version(version)
+        end
       end
 
       def prefix(options = {})

lib/shopify_api/resources/discount_code_batch.rb

@@ -12,7 +12,9 @@ module ShopifyAPI
     def discount_code_job
       @discount_codes ||= begin
         if id
-          path = self.class.api_version.construct_api_path("price_rules/#{price_rule_id}/batch/#{id}/discount_codes.json")
+          path = self.class.api_version.construct_api_path(
+            "price_rules/#{price_rule_id}/batch/#{id}/discount_codes.json"
+          )
           discount_codes = ShopifyAPI::DiscountCode.find(:all, from: path)
           discount_codes.each do |code|
             errors = code.attributes['errors']

lib/shopify_api/resources/recurring_application_charge.rb

@@ -25,7 +25,9 @@ module ShopifyAPI
     end
 
     def customize(customize_recurring_app_charge_params = {})
-      load_attributes_from_response(put(:customize, recurring_application_charge: customize_recurring_app_charge_params ))
+      load_attributes_from_response(
+        put(:customize, recurring_application_charge: customize_recurring_app_charge_params )
+      )
     end
   end
 end

lib/shopify_api/session.rb

@@ -69,7 +69,9 @@ module ShopifyAPI
         params = (params.respond_to?(:to_unsafe_hash) ? params.to_unsafe_hash : params).with_indifferent_access
         return false unless (signature = params[:hmac])
 
-        calculated_signature = OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new('SHA256'), secret, encoded_params_for_signature(params))
+        calculated_signature = OpenSSL::HMAC.hexdigest(
+          OpenSSL::Digest.new('SHA256'), secret, encoded_params_for_signature(params)
+        )
 
         Rack::Utils.secure_compare(calculated_signature, signature)
       end
@@ -132,7 +134,11 @@ module ShopifyAPI
     end
 
     def api_version=(version)
-      @api_version = ApiVersion::NullVersion.matches?(version) ? ApiVersion::NullVersion : ApiVersion.find_version(version)
+      @api_version = if ApiVersion::NullVersion.matches?(version)
+        ApiVersion::NullVersion
+      else
+        ApiVersion.find_version(version)
+      end
     end
 
     def valid?

shopify_api.gemspec

@@ -7,7 +7,12 @@ Gem::Specification.new do |s|
   s.author = "Shopify"
 
   s.summary = %q{The Shopify API gem is a lightweight gem for accessing the Shopify admin REST web services}
-  s.description = %q{The Shopify API gem allows Ruby developers to programmatically access the admin section of Shopify stores. The API is implemented as JSON or XML over HTTP using all four verbs (GET/POST/PUT/DELETE). Each resource, like Order, Product, or Collection, has its own URL and is manipulated in isolation.}
+  s.description = <<~HERE
+    The Shopify API gem allows Ruby developers to programmatically access the admin
+    section of Shopify stores. The API is implemented as JSON or XML over HTTP using
+    all four verbs (GET/POST/PUT/DELETE). Each resource, like Order, Product, or
+    Collection, has its own URL and is manipulated in isolation.
+  HERE
   s.email = %q{developers@jadedpixel.com}
   s.homepage = %q{http://www.shopify.com/partners/apps}
 

test/access_token_test.rb

@@ -3,13 +3,14 @@ require 'test_helper'
 class AccessTokenTest < Test::Unit::TestCase
 
   def test_delegate_access_token
-    fake("access_tokens/delegate.json?delegate_access_scope%5B%5D=write_orders&" \
+    fake(
+      "access_tokens/delegate.json?delegate_access_scope%5B%5D=write_orders&" \
       "delegate_access_scope%5B%5D=read_products&expires_in=",
       method: :post,
       status: 201,
       body: load_fixture('access_token_delegate'),
-      extension: false)
-
+      extension: false
+    )
     delegate_scope = ['write_orders', 'read_products']
     token = ShopifyAPI::AccessToken.delegate(delegate_scope)
 

test/api_version_test.rb

@@ -45,7 +45,7 @@ class ApiVersionTest < Test::Unit::TestCase
   test "find_version does raise when coercing a string if no versions are defined when version_lookup_mode is :raise_on_unknown" do
     refute ShopifyAPI::ApiVersion.versions['made up version']
     ShopifyAPI::ApiVersion.version_lookup_mode = :raise_on_unknown
-    assert_raises ShopifyAPI::ApiVersion::UnknownVersion do
+    assert_raises(ShopifyAPI::ApiVersion::UnknownVersion) do
       ShopifyAPI::ApiVersion.find_version('made up version')
     end
   end
@@ -54,7 +54,7 @@ class ApiVersionTest < Test::Unit::TestCase
     ShopifyAPI::ApiVersion.clear_known_versions
     ShopifyAPI::ApiVersion.version_lookup_mode = :define_on_unknown
     assert_equal :define_on_unknown, ShopifyAPI::ApiVersion.version_lookup_mode
-    assert_raises ArgumentError do
+    assert_raises(ArgumentError) do
       ShopifyAPI::ApiVersion.find_version(ShopifyAPI::ApiVersion::NullVersion)
     end
   end

test/application_charge_test.rb

@@ -11,7 +11,11 @@ class ApplicationChargeTest < Test::Unit::TestCase
         return_url: "http://google.com"
     )
 
-    assert_equal('https://this-is-my-test-shop.myshopify.com/admin/charges/803742/confirm_application_charge?signature=BAhpA55DDA%3D%3D--55b44e274e438c619be4631c804abcbcb6ee915a', charge.confirmation_url)
+    assert_equal(
+      'https://this-is-my-test-shop.myshopify.com/admin/charges/803742/confirm_application_charge?' \
+        'signature=BAhpA55DDA%3D%3D--55b44e274e438c619be4631c804abcbcb6ee915a',
+      charge.confirmation_url
+    )
   end
 
   def test_get_application_charge

test/asset_test.rb

@@ -7,12 +7,19 @@ class AssetTest < Test::Unit::TestCase
   end
 
   def test_get_asset_namespaced
-    fake("themes/1/assets.json?asset%5Bkey%5D=templates%2Findex.liquid&theme_id=1", extension: false, method: :get, body: load_fixture('asset'))
+    fake(
+      "themes/1/assets.json?asset%5Bkey%5D=templates%2Findex.liquid&theme_id=1",
+      extension: false,
+      method: :get,
+      body: load_fixture('asset')
+    )
     ShopifyAPI::Asset.find('templates/index.liquid', params: { theme_id: 1 })
   end
 
   def test_get_asset
-    fake("assets.json?asset%5Bkey%5D=templates%2Findex.liquid", extension: false, method: :get, body: load_fixture('asset'))
+    fake(
+      "assets.json?asset%5Bkey%5D=templates%2Findex.liquid", extension: false, method: :get, body: load_fixture('asset')
+    )
     ShopifyAPI::Asset.find('templates/index.liquid')
   end
 end

test/assigned_fulfillment_order_test.rb

@@ -15,7 +15,7 @@ class AssignedFulFillmentOrderTest < Test::Unit::TestCase
       should "raise NotImplementedError when api_version is older than 2020-01" do
         url_prefix_for_activated_session_for('2019-10')
 
-        assert_raises NotImplementedError do
+        assert_raises(NotImplementedError) do
           ShopifyAPI::AssignedFulfillmentOrder.new(ActiveSupport::JSON.decode(@fulfillment_order_fixture))
         end
       end
@@ -31,7 +31,7 @@ class AssignedFulFillmentOrderTest < Test::Unit::TestCase
           body: @fulfillment_order_fixture,
           extension: false
 
-        assert_raises NotImplementedError do
+        assert_raises(NotImplementedError) do
           ShopifyAPI::AssignedFulfillmentOrder.all(params: { assigned_status: 'cancellation_requested' })
         end
       end

test/base_test.rb

@@ -16,26 +16,26 @@ class BaseTest < Test::Unit::TestCase
   test '#activate_session should set site and headers for given session' do
     ShopifyAPI::Base.activate_session(@session1)
 
-    assert_nil ActiveResource::Base.site
-    assert_equal 'https://shop1.myshopify.com', ShopifyAPI::Base.site.to_s
-    assert_equal 'https://shop1.myshopify.com', ShopifyAPI::Shop.site.to_s
+    assert_nil(ActiveResource::Base.site)
+    assert_equal('https://shop1.myshopify.com', ShopifyAPI::Base.site.to_s)
+    assert_equal('https://shop1.myshopify.com', ShopifyAPI::Shop.site.to_s)
 
-    assert_nil ActiveResource::Base.headers['X-Shopify-Access-Token']
-    assert_equal 'token1', ShopifyAPI::Base.headers['X-Shopify-Access-Token']
-    assert_equal 'token1', ShopifyAPI::Shop.headers['X-Shopify-Access-Token']
+    assert_nil(ActiveResource::Base.headers['X-Shopify-Access-Token'])
+    assert_equal('token1', ShopifyAPI::Base.headers['X-Shopify-Access-Token'])
+    assert_equal('token1', ShopifyAPI::Shop.headers['X-Shopify-Access-Token'])
   end
 
   test '#clear_session should clear base site settings from Base' do
     ShopifyAPI::Base.site = "https://foo:bar@www.zombo.com"
 
-    assert_equal "foo", ShopifyAPI::Base.user
-    assert_equal "bar", ShopifyAPI::Base.password
+    assert_equal("foo", ShopifyAPI::Base.user)
+    assert_equal("bar", ShopifyAPI::Base.password)
 
     ShopifyAPI::Base.clear_session
 
-    assert_nil ShopifyAPI::Base.user
-    assert_nil ShopifyAPI::Base.password
-    assert_nil ShopifyAPI::Base.site
+    assert_nil(ShopifyAPI::Base.user)
+    assert_nil(ShopifyAPI::Base.password)
+    assert_nil(ShopifyAPI::Base.site)
   end
 
   # test to  check session reset api version remains the same after session reset
@@ -43,28 +43,28 @@ class BaseTest < Test::Unit::TestCase
     ShopifyAPI::Base.site = "https://zoo:lion@www.zoo.com"
 
 
-    assert_equal "zoo", ShopifyAPI::Base.user
-    assert_equal "lion", ShopifyAPI::Base.password
+    assert_equal("zoo", ShopifyAPI::Base.user)
+    assert_equal("lion", ShopifyAPI::Base.password)
 
     ShopifyAPI::Base.clear_session
 
-    assert_nil ShopifyAPI::Base.user
-    assert_nil ShopifyAPI::Base.password
-    assert_nil ShopifyAPI::Base.site
-    assert_equal ShopifyAPI::Base.api_version,@session1.api_version
+    assert_nil(ShopifyAPI::Base.user)
+    assert_nil(ShopifyAPI::Base.password)
+    assert_nil(ShopifyAPI::Base.site)
+    assert_equal(ShopifyAPI::Base.api_version,@session1.api_version)
   end
 
   test '#clear_session should clear site and headers from Base' do
     ShopifyAPI::Base.activate_session(@session1)
     ShopifyAPI::Base.clear_session
 
-    assert_nil ActiveResource::Base.site
-    assert_nil ShopifyAPI::Base.site
-    assert_nil ShopifyAPI::Shop.site
+    assert_nil(ActiveResource::Base.site)
+    assert_nil(ShopifyAPI::Base.site)
+    assert_nil(ShopifyAPI::Shop.site)
 
-    assert_nil ActiveResource::Base.headers['X-Shopify-Access-Token']
-    assert_nil ShopifyAPI::Base.headers['X-Shopify-Access-Token']
-    assert_nil ShopifyAPI::Shop.headers['X-Shopify-Access-Token']
+    assert_nil(ActiveResource::Base.headers['X-Shopify-Access-Token'])
+    assert_nil(ShopifyAPI::Base.headers['X-Shopify-Access-Token'])
+    assert_nil(ShopifyAPI::Shop.headers['X-Shopify-Access-Token'])
   end
 
   test '#activate_session with one session, then clearing and activating with another session should send request to correct shop' do
@@ -72,17 +72,17 @@ class BaseTest < Test::Unit::TestCase
     ShopifyAPI::Base.clear_session
     ShopifyAPI::Base.activate_session(@session2)
 
-    assert_nil ActiveResource::Base.site
-    assert_equal 'https://shop2.myshopify.com', ShopifyAPI::Base.site.to_s
-    assert_equal 'https://shop2.myshopify.com', ShopifyAPI::Shop.site.to_s
+    assert_nil(ActiveResource::Base.site)
+    assert_equal('https://shop2.myshopify.com', ShopifyAPI::Base.site.to_s)
+    assert_equal('https://shop2.myshopify.com', ShopifyAPI::Shop.site.to_s)
 
-    assert_nil ActiveResource::Base.headers['X-Shopify-Access-Token']
-    assert_equal 'token2', ShopifyAPI::Base.headers['X-Shopify-Access-Token']
-    assert_equal 'token2', ShopifyAPI::Shop.headers['X-Shopify-Access-Token']
+    assert_nil(ActiveResource::Base.headers['X-Shopify-Access-Token'])
+    assert_equal('token2', ShopifyAPI::Base.headers['X-Shopify-Access-Token'])
+    assert_equal('token2', ShopifyAPI::Shop.headers['X-Shopify-Access-Token'])
   end
 
   test '#activate_session with nil raises an InvalidSessionError' do
-    assert_raises ShopifyAPI::Base::InvalidSessionError do
+    assert_raises(ShopifyAPI::Base::InvalidSessionError) do
       ShopifyAPI::Base.activate_session(nil)
     end
   end
@@ -98,7 +98,7 @@ class BaseTest < Test::Unit::TestCase
 
   test "#headers includes the User-Agent" do
     assert_not_includes ActiveResource::Base.headers.keys, 'User-Agent'
-    assert_includes ShopifyAPI::Base.headers.keys, 'User-Agent'
+    assert_includes(ShopifyAPI::Base.headers.keys, 'User-Agent')
     thread = Thread.new do
       assert_includes(ShopifyAPI::Base.headers.keys, 'User-Agent')
     end
@@ -116,22 +116,22 @@ class BaseTest < Test::Unit::TestCase
   end
 
   test "prefix= will raise an error if value starts with with /admin" do
-    assert_raises ArgumentError do
+    assert_raises(ArgumentError) do
       TestResource.prefix = '/admin/old/prefix/structure/'
     end
   end
 
   test "#headers propagates changes to subclasses" do
     ShopifyAPI::Base.headers['X-Custom'] = "the value"
-    assert_equal "the value", ShopifyAPI::Base.headers['X-Custom']
-    assert_equal "the value", ShopifyAPI::Product.headers['X-Custom']
+    assert_equal("the value", ShopifyAPI::Base.headers['X-Custom'])
+    assert_equal("the value", ShopifyAPI::Product.headers['X-Custom'])
   end
 
   test "#headers clears changes to subclasses" do
     ShopifyAPI::Base.headers['X-Custom'] = "the value"
-    assert_equal "the value", ShopifyAPI::Product.headers['X-Custom']
+    assert_equal("the value", ShopifyAPI::Product.headers['X-Custom'])
     ShopifyAPI::Base.headers['X-Custom'] = nil
-    assert_nil ShopifyAPI::Product.headers['X-Custom']
+    assert_nil(ShopifyAPI::Product.headers['X-Custom'])
   end
 
   test "#headers set in the main thread affect spawned threads" do
@@ -145,7 +145,7 @@ class BaseTest < Test::Unit::TestCase
     Thread.new do
       ShopifyAPI::Base.headers['X-Custom'] = "the value"
     end.join
-    assert_nil ShopifyAPI::Base.headers['X-Custom']
+    assert_nil(ShopifyAPI::Base.headers['X-Custom'])
   end
 
   test "using a different version changes the url" do
@@ -168,30 +168,30 @@ class BaseTest < Test::Unit::TestCase
     )
 
     ShopifyAPI::Base.activate_session(release_2019_01)
-    assert_equal 1, ShopifyAPI::Shop.current.id
+    assert_equal(1, ShopifyAPI::Shop.current.id)
 
     ShopifyAPI::Base.activate_session(unstable_version)
-    assert_equal 2, ShopifyAPI::Shop.current.id
+    assert_equal(2, ShopifyAPI::Shop.current.id)
   end
 
   test "#api_version= should set ApiVersion" do
     ShopifyAPI::Base.api_version = '2019-04'
-    assert_equal '2019-04', ShopifyAPI::Base.api_version.to_s
+    assert_equal('2019-04', ShopifyAPI::Base.api_version.to_s)
   end
 
   test "#api_version= nil should set ApiVersion to ShopifyAPI::ApiVersion::NullVersion" do
     ShopifyAPI::Base.api_version = nil
-    assert_equal ShopifyAPI::ApiVersion::NullVersion, ShopifyAPI::Base.api_version
+    assert_equal(ShopifyAPI::ApiVersion::NullVersion, ShopifyAPI::Base.api_version)
   end
 
   test "#api_version= ShopifyAPI::ApiVersion::NullVersion should set ApiVersion to ShopifyAPI::ApiVersion::NullVersion" do
     ShopifyAPI::Base.api_version = ShopifyAPI::ApiVersion::NullVersion
-    assert_equal ShopifyAPI::ApiVersion::NullVersion, ShopifyAPI::Base.api_version
+    assert_equal(ShopifyAPI::ApiVersion::NullVersion, ShopifyAPI::Base.api_version)
   end
 
   test "#version_validation! does not raise is api_version is newer or equal to minimum supported version" do
     ShopifyAPI::Base.api_version = '2020-01'
-    assert_nil ShopifyAPI::Base::version_validation!('2020-01')
+    assert_nil(ShopifyAPI::Base::version_validation!('2020-01'))
   end
 
   test "#version_validation! raises NotImplemetedError if api_version is older than minimum supported version" do
@@ -199,7 +199,7 @@ class BaseTest < Test::Unit::TestCase
     exception = assert_raises(NotImplementedError) do
       ShopifyAPI::Base::version_validation!('2020-01')
     end
-    assert_equal 'The minimum supported version is 2020-01.', exception.message
+    assert_equal('The minimum supported version is 2020-01.', exception.message)
   end
 
 

test/blog_test.rb

@@ -1,8 +1,8 @@
 require 'test_helper'
 class BlogTest < Test::Unit::TestCase
   test "blog creation" do
-    fake "blogs", method: :post, status: 202, body: load_fixture('blog')
+    fake("blogs", method: :post, status: 202, body: load_fixture('blog'))
     ShopifyAPI::Blog.create(title: "Test Blog")
-    assert_equal '{"blog":{"title":"Test Blog"}}', WebMock.last_request.body
+    assert_equal('{"blog":{"title":"Test Blog"}}', WebMock.last_request.body)
   end
 end

test/carrier_service_test.rb

@@ -2,16 +2,16 @@ require 'test_helper'
 
 class CarrierServiceTest < Test::Unit::TestCase
   test 'new should create carrier service' do
-    fake "carrier_services", method: :post, body: load_fixture('carrier_service')
+    fake("carrier_services", method: :post, body: load_fixture('carrier_service'))
     carrier_service = ShopifyAPI::CarrierService.new(name: "Some Postal Service")
     carrier_service.save
-    assert_equal "Some Postal Service" , carrier_service.name
+    assert_equal("Some Postal Service" , carrier_service.name)
   end
 
   test 'find should return the carrier service' do
-    fake "carrier_services/123456", method: :get, body: load_fixture('carrier_service')
+    fake("carrier_services/123456", method: :get, body: load_fixture('carrier_service'))
     carrier_service = ShopifyAPI::CarrierService.find(123456)
-    assert_equal 123456 , carrier_service.id
-    assert_equal "Some Postal Service", carrier_service.name
+    assert_equal(123456 , carrier_service.id)
+    assert_equal("Some Postal Service", carrier_service.name)
   end
 end

test/collect_test.rb

@@ -2,8 +2,8 @@ require 'test_helper'
 
 class CollectTest < Test::Unit::TestCase
   test "#create should create a collect" do
-    fake "collects", method: :post, status: 201, body: load_fixture('collect')
+    fake("collects", method: :post, status: 201, body: load_fixture('collect'))
     link = ShopifyAPI::Collect.create(product_id: 921728736, collection_id: 841564295)
-    assert_equal 841564295, link.id
+    assert_equal(841564295, link.id)
   end
 end

test/collection_listing_test.rb

@@ -32,7 +32,12 @@ class CollectionListingTest < Test::Unit::TestCase
   end
 
   def test_get_collection_listing_product_ids
-    fake("collection_listings/1/product_ids", method: :get, status: 201, body: load_fixture('collection_listing_product_ids'))
+    fake(
+      "collection_listings/1/product_ids",
+      method: :get,
+      status: 201,
+      body: load_fixture('collection_listing_product_ids')
+    )
 
     collection_listing = ShopifyAPI::CollectionListing.new(collection_id: 1)
 

test/collection_test.rb

@@ -42,7 +42,7 @@ class CollectionTest < Test::Unit::TestCase
 
     collection = ShopifyAPI::Collection.find(1)
 
-    assert_raises NotImplementedError do
+    assert_raises(NotImplementedError) do
       collection.products
     end
   end

test/currency_test.rb

@@ -10,11 +10,11 @@ class CurrencyTest < Test::Unit::TestCase
   context "Currency" do
     should 'return a list of enabled currencies' do
       currencies = ShopifyAPI::Currency.all
-      assert_equal 4, currencies.count
-      assert_equal %w(AUD EUR GBP HKD), currencies.map(&:currency)
-      assert_equal [true, true, true, false], currencies.map(&:enabled)
+      assert_equal(4, currencies.count)
+      assert_equal(%w(AUD EUR GBP HKD), currencies.map(&:currency))
+      assert_equal([true, true, true, false], currencies.map(&:enabled))
       currencies.each do |currency|
-        assert_equal "2018-10-03T14:44:08-04:00", currency.rate_updated_at
+        assert_equal("2018-10-03T14:44:08-04:00", currency.rate_updated_at)
       end
     end
   end

test/custom_collection_test.rb

@@ -2,8 +2,8 @@ require 'test_helper'
 
 class CustomCollectionTest < Test::Unit::TestCase
   test "#create should create a custom collection" do
-    fake "custom_collections", method: :post, status: 201, body: load_fixture('custom_collection')
+    fake("custom_collections", method: :post, status: 201, body: load_fixture('custom_collection'))
     link = ShopifyAPI::CustomCollection.create(title: "Macbooks", image: { src: "http://example.com/rails_logo.gif" })
-    assert_equal 1063001463, link.id
+    assert_equal(1063001463, link.id)
   end
 end

test/customer_saved_search_test.rb

@@ -7,13 +7,21 @@ class CustomerSavedSearchTest < Test::Unit::TestCase
   end
 
   def test_get_customers_from_customer_saved_search
-    fake('customers/search.json?customer_saved_search_id=8899730', body: load_fixture('customer_saved_search_customers'), extension: false)
+    fake(
+      'customers/search.json?customer_saved_search_id=8899730',
+      body: load_fixture('customer_saved_search_customers'),
+      extension: false
+    )
     assert_equal(1, @customer_saved_search.customers.length)
     assert_equal(112223902, @customer_saved_search.customers.first.id)
   end
 
   def test_get_customers_from_customer_saved_search_with_params
-    fake('customers/search.json?customer_saved_search_id=8899730&limit=1', body: load_fixture('customer_saved_search_customers'), extension: false)
+    fake(
+      'customers/search.json?customer_saved_search_id=8899730&limit=1',
+      body: load_fixture('customer_saved_search_customers'),
+      extension: false
+    )
     customers = @customer_saved_search.customers(limit: 1)
     assert_equal(1, customers.length)
     assert_equal(112223902, customers.first.id)

test/customer_test.rb

@@ -10,41 +10,49 @@ class CustomerTest < Test::Unit::TestCase
   end
 
   test "search should get a customers collection" do
-    fake "customers/search.json?query=Bob+country%3AUnited+States", extension: false, body: load_fixture('customers_search')
+    fake(
+      "customers/search.json?query=Bob+country%3AUnited+States",
+      extension: false,
+      body: load_fixture('customers_search')
+    )
 
     results = ShopifyAPI::Customer.search(query: 'Bob country:United States')
-    assert_equal 'Bob', results.first.first_name
+    assert_equal('Bob', results.first.first_name)
   end
 
   test "account_activation_url should create an account activation url" do
-    fake "customers/207119551/account_activation_url", method: :post, body: load_fixture('customers_account_activation_url')
+    fake(
+      "customers/207119551/account_activation_url",
+      method: :post,
+      body: load_fixture('customers_account_activation_url')
+    )
 
     activation_url = "http://apple.myshopify.com/account/activate/207119551/86688abf23572680740b1c062fa37111-1458248616"
-    assert_equal activation_url, @customer.account_activation_url
+    assert_equal(activation_url, @customer.account_activation_url)
   end
 
   test "#send_invite with no params" do
     customer_invite_fixture = load_fixture('customer_invite')
     customer_invite = ActiveSupport::JSON.decode(customer_invite_fixture)
-    fake 'customers/207119551/send_invite', method: :post, body: customer_invite_fixture
+    fake('customers/207119551/send_invite', method: :post, body: customer_invite_fixture)
 
     customer_invite_response = @customer.send_invite
 
-    assert_equal '{"customer_invite":{}}', WebMock.last_request.body
-    assert_kind_of ShopifyAPI::CustomerInvite, customer_invite_response
-    assert_equal customer_invite['customer_invite']['to'], customer_invite_response.to
+    assert_equal('{"customer_invite":{}}', WebMock.last_request.body)
+    assert_kind_of(ShopifyAPI::CustomerInvite, customer_invite_response)
+    assert_equal(customer_invite['customer_invite']['to'], customer_invite_response.to)
   end
 
   test "#send_invite with params" do
     customer_invite_fixture = load_fixture('customer_invite')
     customer_invite = ActiveSupport::JSON.decode(customer_invite_fixture)
-    fake 'customers/207119551/send_invite', method: :post, body: customer_invite_fixture
+    fake('customers/207119551/send_invite', method: :post, body: customer_invite_fixture)
 
 
     customer_invite_response = @customer.send_invite(ShopifyAPI::CustomerInvite.new(customer_invite['customer_invite']))
 
-    assert_equal customer_invite, ActiveSupport::JSON.decode(WebMock.last_request.body)
-    assert_kind_of ShopifyAPI::CustomerInvite, customer_invite_response
-    assert_equal customer_invite['customer_invite']['to'], customer_invite_response.to
+    assert_equal(customer_invite, ActiveSupport::JSON.decode(WebMock.last_request.body))
+    assert_kind_of(ShopifyAPI::CustomerInvite, customer_invite_response)
+    assert_equal(customer_invite['customer_invite']['to'], customer_invite_response.to)
   end
 end

test/detailed_log_subscriber_test.rb

@@ -10,17 +10,20 @@ class LogSubscriberTest < Test::Unit::TestCase
   def setup
     super
     @page = { page: { id: 1, title: 'Shopify API' } }.to_json
-    @ua_header = "\"User-Agent\"=>\"ShopifyAPI/#{ShopifyAPI::VERSION} ActiveResource/#{ActiveResource::VERSION::STRING} Ruby/#{RUBY_VERSION}\""
+    @ua_header = "\"User-Agent\"=>\"ShopifyAPI/#{ShopifyAPI::VERSION} " \
+      "ActiveResource/#{ActiveResource::VERSION::STRING} Ruby/#{RUBY_VERSION}\""
     @request_headers = "Headers: {\"Accept\"=>\"application/json\", " \
       "#{@ua_header}, \"X-Shopify-Access-Token\"=>\"access_token\"}"
 
     ShopifyAPI::Base.clear_session
-    fake("apis",
+    fake(
+      "apis",
       url: "https://app.shopify.com/services/apis.json",
       method: :get,
       status: 200,
       api_version: :stub,
-      body: load_fixture('apis'))
+      body: load_fixture('apis')
+    )
     ShopifyAPI::ApiVersion.fetch_known_versions
     session = ShopifyAPI::Session.new(
       domain: "https://this-is-my-test-shop.myshopify.com",
@@ -45,7 +48,7 @@ class LogSubscriberTest < Test::Unit::TestCase
   end
 
   test "logging on #find" do
-    fake "pages/1", method: :get, body: @page
+    fake("pages/1", method: :get, body: @page)
 
     ShopifyAPI::Page.find(1)
 
@@ -64,9 +67,9 @@ class LogSubscriberTest < Test::Unit::TestCase
   end
 
   test "logging on #find with an error" do
-    fake "pages/2", method: :get, body: nil, status: 404
+    fake("pages/2", method: :get, body: nil, status: 404)
 
-    assert_raises ActiveResource::ResourceNotFound do
+    assert_raises(ActiveResource::ResourceNotFound) do
       ShopifyAPI::Page.find(2)
     end
 
@@ -103,7 +106,7 @@ class LogSubscriberTest < Test::Unit::TestCase
 
     ShopifyAPI::Page.find(1)
 
-    assert_equal 1, @logger.logged(:warn).size
+    assert_equal(1, @logger.logged(:warn).size)
 
     assert_match(
       %r{\[DEPRECATED\] ShopifyAPI made a call to GET /admin/api/2019-01/pages/1.json},
@@ -125,7 +128,7 @@ class LogSubscriberTest < Test::Unit::TestCase
 
     ShopifyAPI::Page.find(1)
 
-    assert_equal 1, @logger.logged(:warn).size
+    assert_equal(1, @logger.logged(:warn).size)
 
     assert_match(
       %r{\[API Version Warning\] ShopifyAPI made a call to GET /admin/api/2019-01/pages/1.json},

test/discount_code_batch_test.rb

@@ -14,11 +14,12 @@ class DiscountCodeBatchTest < Test::Unit::TestCase
   end
 
   def test_get_batch_discount_codes
-    fake('price_rules/102586120/batch/989355119/discount_codes',
+    fake(
+      'price_rules/102586120/batch/989355119/discount_codes',
       method: :get,
       status: 200,
-      body: load_fixture('discount_code_batch_discount_codes'))
-
+      body: load_fixture('discount_code_batch_discount_codes')
+    )
     batch = ShopifyAPI::DiscountCodeBatch.find(989355119, params: { price_rule_id: 102586120 })
     discount_code_job = batch.discount_code_job
 

test/discount_code_test.rb

@@ -38,7 +38,12 @@ class DiscountCodeTest < Test::Unit::TestCase
     discount_code_response['discount_code']['code'] = "WINTERSALE50"
     @discount_code.code = "WINTERSALE50"
 
-    fake('price_rules/102586120/discount_codes/1002091923', method: :put, status: 200, body: ActiveSupport::JSON.encode(discount_code_response))
+    fake(
+      'price_rules/102586120/discount_codes/1002091923',
+      method: :put,
+      status: 200,
+      body: ActiveSupport::JSON.encode(discount_code_response)
+    )
 
     @discount_code.save
 

test/draft_order_test.rb

@@ -79,7 +79,9 @@ class DraftOrderTest < Test::Unit::TestCase
     draft_order_invoice = ActiveSupport::JSON.decode(draft_order_invoice_fixture)
     fake('draft_orders/517119332/send_invoice', method: :post, body: draft_order_invoice_fixture)
 
-    draft_order_invoice_response = @draft_order.send_invoice(ShopifyAPI::DraftOrderInvoice.new(draft_order_invoice['draft_order_invoice']))
+    draft_order_invoice_response = @draft_order.send_invoice(
+      ShopifyAPI::DraftOrderInvoice.new(draft_order_invoice['draft_order_invoice'])
+    )
 
     assert_equal(draft_order_invoice, ActiveSupport::JSON.decode(WebMock.last_request.body))
     assert_kind_of(ShopifyAPI::DraftOrderInvoice, draft_order_invoice_response)
@@ -94,9 +96,16 @@ class DraftOrderTest < Test::Unit::TestCase
   def test_add_metafields_to_draft_order
     fake('draft_orders/517119332/metafields', method: :post, status: 201, body: load_fixture('metafield'))
 
-    field = @draft_order.add_metafield(ShopifyAPI::Metafield.new(namespace: 'contact', key: 'email', value: '123@example.com', value_type: 'string'))
+    field = @draft_order.add_metafield(
+      ShopifyAPI::Metafield.new(namespace: 'contact', key: 'email', value: '123@example.com', value_type: 'string')
+    )
 
-    assert_equal(ActiveSupport::JSON.decode('{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'), ActiveSupport::JSON.decode(WebMock.last_request.body))
+    assert_equal(
+      ActiveSupport::JSON.decode(
+        '{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'
+      ),
+      ActiveSupport::JSON.decode(WebMock.last_request.body)
+    )
     assert(!field.new_record?)
     assert_equal('contact', field.namespace)
     assert_equal('email', field.key)
@@ -140,7 +149,13 @@ class DraftOrderTest < Test::Unit::TestCase
     completed_fixture = load_fixture('draft_order_completed')
     completed_draft = ActiveSupport::JSON.decode(completed_fixture)['draft_order']
     complete_params = { payment_pending: true }
-    fake('draft_orders/517119332/complete.json?payment_pending=true', extension: false, method: :put, status: 200, body: completed_fixture)
+    fake(
+      'draft_orders/517119332/complete.json?payment_pending=true',
+      extension: false,
+      method: :put,
+      status: 200,
+      body: completed_fixture
+    )
 
     @draft_order.complete(complete_params)
 

test/fulfillment_event_test.rb

@@ -2,10 +2,11 @@ require 'test_helper'
 
 class FulFillmentEventTest < Test::Unit::TestCase
   def test_find_all_resources
-    fake('orders/450789469/fulfillments/255858046/events',
-         method: :get,
-         body: "[#{load_fixture('fulfillment_event')}]")
-
+    fake(
+      'orders/450789469/fulfillments/255858046/events',
+      method: :get,
+      body: "[#{load_fixture('fulfillment_event')}]"
+    )
     events = ShopifyAPI::FulfillmentEvent.all(
       params: { fulfillment_id: 255858046, order_id: 450789469 }
     )
@@ -14,10 +15,11 @@ class FulFillmentEventTest < Test::Unit::TestCase
   end
 
   def test_find_a_resource
-    fake('orders/450789469/fulfillments/255858046/events/334455',
-         method: :get,
-         body: load_fixture('fulfillment_event'))
-
+    fake(
+      'orders/450789469/fulfillments/255858046/events/334455',
+      method: :get,
+      body: load_fixture('fulfillment_event')
+    )
     event = ShopifyAPI::FulfillmentEvent.find(
       334455, params: { fulfillment_id: 255858046, order_id: 450789469 }
     )
@@ -40,10 +42,11 @@ class FulFillmentEventTest < Test::Unit::TestCase
   end
 
   def test_update_a_resource
-    fake('orders/450789469/fulfillments/255858046/events/334455',
-         method: :get,
-         body: load_fixture('fulfillment_event'))
-
+    fake(
+      'orders/450789469/fulfillments/255858046/events/334455',
+      method: :get,
+      body: load_fixture('fulfillment_event')
+    )
     event = ShopifyAPI::FulfillmentEvent.find(
       334455, params: { fulfillment_id: 255858046, order_id: 450789469 }
     )
@@ -54,10 +57,11 @@ class FulFillmentEventTest < Test::Unit::TestCase
   end
 
   def test_destroy_a_resource
-    fake('orders/450789469/fulfillments/255858046/events/334455',
-         method: :get,
-         body: load_fixture('fulfillment_event'))
-
+    fake(
+      'orders/450789469/fulfillments/255858046/events/334455',
+      method: :get,
+      body: load_fixture('fulfillment_event')
+    )
     event = ShopifyAPI::FulfillmentEvent.find(
       334455, params: { fulfillment_id: 255858046, order_id: 450789469 }
     )

test/fulfillment_order_test.rb

@@ -8,10 +8,12 @@ class FulFillmentOrderTest < Test::Unit::TestCase
     super
     @url_prefix = url_prefix_for_activated_session_for('2020-01')
 
-    fake('fulfillment_orders',
+    fake(
+      'fulfillment_orders',
       url: "#{@url_prefix}/fulfillment_orders/519788021.json",
       method: :get,
-      body: load_fixture('fulfillment_order'))
+      body: load_fixture('fulfillment_order')
+    )
   end
 
   context "FulfillmentOrder" do
@@ -34,11 +36,12 @@ class FulFillmentOrderTest < Test::Unit::TestCase
       should "raise NotImplementedError when api_version is older than 2020-01" do
         @url_prefix = url_prefix_for_activated_session_for('2019-10')
 
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021.json",
           method: :get,
           body: load_fixture('fulfillment_order')
-
+        )
         exception = assert_raises(NotImplementedError) do
           ShopifyAPI::FulfillmentOrder.find(519788021)
         end
@@ -47,7 +50,7 @@ class FulFillmentOrderTest < Test::Unit::TestCase
           exception.message
         )
 
-        assert_raises NotImplementedError do
+        assert_raises(NotImplementedError) do
           ShopifyAPI::FulfillmentOrder.all(params: { order_id: 450789469 })
         end
       end
@@ -56,32 +59,32 @@ class FulFillmentOrderTest < Test::Unit::TestCase
     context "#find" do
       should "be able to find fulfillment order" do
         fulfillment_order = ShopifyAPI::FulfillmentOrder.find(519788021)
-        assert fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder)
-        assert_equal 519788021, fulfillment_order.id
-        assert_equal 450789469, fulfillment_order.order_id
+        assert(fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder))
+        assert_equal(519788021, fulfillment_order.id)
+        assert_equal(450789469, fulfillment_order.order_id)
       end
     end
 
     context "#all" do
       should "be able to list fulfillment orders for an order" do
-        fake 'orders',
+        fake('orders',
           url: "#{@url_prefix}/orders/450789469/fulfillment_orders.json",
           method: :get,
           body: load_fixture('fulfillment_orders')
-
+        )
         fulfillment_orders = ShopifyAPI::FulfillmentOrder.all(
           params: { order_id: 450789469 }
         )
 
-        assert_equal [519788021, 519788022], fulfillment_orders.map(&:id).sort
+        assert_equal([519788021, 519788022], fulfillment_orders.map(&:id).sort)
         fulfillment_orders.each do |fulfillment_order|
-          assert fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder)
-          assert_equal 450789469, fulfillment_order.order_id
+          assert(fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder))
+          assert_equal(450789469, fulfillment_order.order_id)
         end
       end
 
       should "require order_id" do
-        assert_raises ShopifyAPI::ValidationException do
+        assert_raises(ShopifyAPI::ValidationException) do
           ShopifyAPI::FulfillmentOrder.all
         end
       end
@@ -90,37 +93,39 @@ class FulFillmentOrderTest < Test::Unit::TestCase
     context "#fulfillments" do
       should "be able to list fulfillments for a fulfillment order" do
         fulfillment_order = ShopifyAPI::FulfillmentOrder.find(519788021)
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/#{fulfillment_order.id}/fulfillments.json",
           method: :get,
           body: load_fixture('fulfillments')
-
+        )
         fulfillments = fulfillment_order.fulfillments
 
-        assert_equal 1, fulfillments.count
+        assert_equal(1, fulfillments.count)
         fulfillment = fulfillments.first
-        assert fulfillment.is_a?(ShopifyAPI::Fulfillment)
-        assert_equal 450789469, fulfillment.order_id
+        assert(fulfillment.is_a?(ShopifyAPI::Fulfillment))
+        assert_equal(450789469, fulfillment.order_id)
       end
     end
 
     context "#locations_for_move" do
       should "be able to list locations for a fulfillment order" do
         fulfillment_order = ShopifyAPI::FulfillmentOrder.find(519788021)
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/#{fulfillment_order.id}/locations_for_move.json",
           method: :get,
           body: load_fixture('fulfillment_order_locations_for_move')
-
+        )
         locations_for_move = fulfillment_order.locations_for_move
 
-        assert_equal 2, locations_for_move.count
+        assert_equal(2, locations_for_move.count)
         location_for_move = locations_for_move.first
-        assert location_for_move.is_a?(ShopifyAPI::FulfillmentOrderLocationsForMove)
+        assert(location_for_move.is_a?(ShopifyAPI::FulfillmentOrderLocationsForMove))
 
         location = location_for_move.location
-        assert location.is_a?(ShopifyAPI::Location)
-        assert_equal 1059367776,location.id
+        assert(location.is_a?(ShopifyAPI::Location))
+        assert_equal(1059367776,location.id)
       end
     end
 
@@ -140,37 +145,38 @@ class FulFillmentOrderTest < Test::Unit::TestCase
           moved_fulfillment_order: fake_moved_fulfillment_order,
           remaining_fulfillment_order: nil,
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/move.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(body)
-
+        )
         response_fulfillment_orders = fulfillment_order.move(new_location_id: new_location_id)
 
-        assert_equal 'closed', fulfillment_order.status
+        assert_equal('closed', fulfillment_order.status)
 
-        assert_equal 3, response_fulfillment_orders.count
+        assert_equal(3, response_fulfillment_orders.count)
         original_fulfillment_order = response_fulfillment_orders['original_fulfillment_order']
         refute_nil original_fulfillment_order
-        assert original_fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder)
-        assert_equal 'closed', original_fulfillment_order.status
+        assert(original_fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder))
+        assert_equal('closed', original_fulfillment_order.status)
 
         moved_fulfillment_order = response_fulfillment_orders['moved_fulfillment_order']
         refute_nil moved_fulfillment_order
-        assert moved_fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder)
-        assert_equal 'open', moved_fulfillment_order.status
-        assert_equal new_location_id, moved_fulfillment_order.assigned_location_id
+        assert(moved_fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder))
+        assert_equal('open', moved_fulfillment_order.status)
+        assert_equal(new_location_id, moved_fulfillment_order.assigned_location_id)
 
         remaining_fulfillment_order = response_fulfillment_orders['remaining_fulfillment_order']
-        assert_nil remaining_fulfillment_order
+        assert_nil(remaining_fulfillment_order)
       end
     end
 
     context "#cancel" do
       should "cancel a fulfillment order" do
         fulfillment_order = ShopifyAPI::FulfillmentOrder.find(519788021)
-        assert_equal 'open', fulfillment_order.status
+        assert_equal('open', fulfillment_order.status)
 
         cancelled = ActiveSupport::JSON.decode(load_fixture('fulfillment_order'))
         cancelled['status'] = 'cancelled'
@@ -178,19 +184,20 @@ class FulFillmentOrderTest < Test::Unit::TestCase
           fulfillment_order: cancelled,
           replacement_fulfillment_order: fulfillment_order,
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/cancel.json",
           method: :post,
           body: ActiveSupport::JSON.encode(body)
-
+        )
         response_fulfillment_orders = fulfillment_order.cancel
 
-        assert_equal 'cancelled', fulfillment_order.status
-        assert_equal 2, response_fulfillment_orders.count
+        assert_equal('cancelled', fulfillment_order.status)
+        assert_equal(2, response_fulfillment_orders.count)
         fulfillment_order = response_fulfillment_orders['fulfillment_order']
-        assert_equal 'cancelled', fulfillment_order.status
+        assert_equal('cancelled', fulfillment_order.status)
         replacement_fulfillment_order = response_fulfillment_orders['replacement_fulfillment_order']
-        assert_equal 'open', replacement_fulfillment_order.status
+        assert_equal('open', replacement_fulfillment_order.status)
       end
     end
 
@@ -206,14 +213,15 @@ class FulFillmentOrderTest < Test::Unit::TestCase
             message: "Test close message."
           }
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/close.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(closed)
-
-        assert fulfillment_order.close(message: "Test close message.")
-        assert_equal 'incomplete', fulfillment_order.status
+        )
+        assert(fulfillment_order.close(message: "Test close message."))
+        assert_equal('incomplete', fulfillment_order.status)
       end
     end
 
@@ -242,12 +250,13 @@ class FulFillmentOrderTest < Test::Unit::TestCase
             message: 'Fulfill this FO, please.'
           }
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/fulfillment_request.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(body)
-
+        )
         fulfillment_order = ShopifyAPI::FulfillmentOrder.find(519788021)
         params = {
           fulfillment_order_line_items: [{ id: 1, quantity: 1 }],
@@ -255,22 +264,22 @@ class FulFillmentOrderTest < Test::Unit::TestCase
         }
         response_fulfillment_orders = fulfillment_order.request_fulfillment(params)
 
-        assert_equal 'closed', fulfillment_order.status
-        assert_equal 3, response_fulfillment_orders.size
+        assert_equal('closed', fulfillment_order.status)
+        assert_equal(3, response_fulfillment_orders.size)
 
         original_fulfillment_order = response_fulfillment_orders['original_fulfillment_order']
-        assert_equal 519788021, original_fulfillment_order.id
-        assert_equal 'closed', original_fulfillment_order.status
+        assert_equal(519788021, original_fulfillment_order.id)
+        assert_equal('closed', original_fulfillment_order.status)
 
         submitted_fulfillment_order = response_fulfillment_orders['submitted_fulfillment_order']
-        assert_equal 2, submitted_fulfillment_order.id
-        assert_equal 'open', submitted_fulfillment_order.status
-        assert_equal 'submitted', submitted_fulfillment_order.request_status
+        assert_equal(2, submitted_fulfillment_order.id)
+        assert_equal('open', submitted_fulfillment_order.status)
+        assert_equal('submitted', submitted_fulfillment_order.request_status)
 
         unsubmitted_fulfillment_order = response_fulfillment_orders['unsubmitted_fulfillment_order']
-        assert_equal 3, unsubmitted_fulfillment_order.id
-        assert_equal 'open', unsubmitted_fulfillment_order.status
-        assert_equal 'unsubmitted', unsubmitted_fulfillment_order.request_status
+        assert_equal(3, unsubmitted_fulfillment_order.id)
+        assert_equal('open', unsubmitted_fulfillment_order.status)
+        assert_equal('unsubmitted', unsubmitted_fulfillment_order.request_status)
       end
 
       should "make a fulfillment request for a fulfillment order excluding unsubmitted" do
@@ -293,12 +302,13 @@ class FulFillmentOrderTest < Test::Unit::TestCase
             message: 'Fulfill this FO, please.'
           }
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/fulfillment_request.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(body)
-
+        )
         fulfillment_order = ShopifyAPI::FulfillmentOrder.find(519788021)
         params = {
           fulfillment_order_line_items: [{ id: 1, quantity: 1 }],
@@ -306,19 +316,19 @@ class FulFillmentOrderTest < Test::Unit::TestCase
         }
         response_fulfillment_orders = fulfillment_order.request_fulfillment(params)
 
-        assert_equal 'closed', fulfillment_order.status
-        assert_equal 3, response_fulfillment_orders.size
+        assert_equal('closed', fulfillment_order.status)
+        assert_equal(3, response_fulfillment_orders.size)
 
         original_fulfillment_order = response_fulfillment_orders['original_fulfillment_order']
-        assert_equal 519788021, original_fulfillment_order.id
-        assert_equal 'closed', original_fulfillment_order.status
+        assert_equal(519788021, original_fulfillment_order.id)
+        assert_equal('closed', original_fulfillment_order.status)
 
         submitted_fulfillment_order = response_fulfillment_orders['submitted_fulfillment_order']
-        assert_equal 2, submitted_fulfillment_order.id
-        assert_equal 'open', submitted_fulfillment_order.status
-        assert_equal 'submitted', submitted_fulfillment_order.request_status
+        assert_equal(2, submitted_fulfillment_order.id)
+        assert_equal('open', submitted_fulfillment_order.status)
+        assert_equal('submitted', submitted_fulfillment_order.request_status)
 
-        assert_nil response_fulfillment_orders['unsubmitted_fulfillment_order']
+        assert_nil(response_fulfillment_orders['unsubmitted_fulfillment_order'])
       end
     end
 
@@ -335,17 +345,18 @@ class FulFillmentOrderTest < Test::Unit::TestCase
         fake_response = {
           fulfillment_order: fulfillment_order.attributes.merge(status: 'in_progress', request_status: 'accepted')
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/fulfillment_request/accept.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(fake_response)
-
+        )
         accepted = fulfillment_order.accept_fulfillment_request(message: message)
 
-        assert_equal true, accepted
-        assert_equal 'in_progress', fulfillment_order.status
-        assert_equal 'accepted', fulfillment_order.request_status
+        assert_equal(true, accepted)
+        assert_equal('in_progress', fulfillment_order.status)
+        assert_equal('accepted', fulfillment_order.request_status)
       end
     end
 
@@ -362,17 +373,18 @@ class FulFillmentOrderTest < Test::Unit::TestCase
         fake_response = {
           fulfillment_order: fulfillment_order.attributes.merge(status: 'open', request_status: 'rejected')
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/fulfillment_request/reject.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(fake_response)
-
+        )
         rejected = fulfillment_order.reject_fulfillment_request(message: message)
 
-        assert_equal true, rejected
-        assert_equal 'open', fulfillment_order.status
-        assert_equal 'rejected', fulfillment_order.request_status
+        assert_equal(true, rejected)
+        assert_equal('open', fulfillment_order.status)
+        assert_equal('rejected', fulfillment_order.request_status)
       end
     end
 
@@ -389,17 +401,18 @@ class FulFillmentOrderTest < Test::Unit::TestCase
         cancelling = ActiveSupport::JSON.decode(load_fixture('fulfillment_order'))
         cancelling['status'] = 'in_progress'
         cancelling['request_status'] = 'cancellation_requested'
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/cancellation_request.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode({ fulfillment_order: cancelling })
-
+        )
         cancelled = fulfillment_order.request_cancellation(message: "Cancelling this please.")
 
-        assert_equal true, cancelled
-        assert_equal 'in_progress', fulfillment_order.status
-        assert_equal 'cancellation_requested', fulfillment_order.request_status
+        assert_equal(true, cancelled)
+        assert_equal('in_progress', fulfillment_order.status)
+        assert_equal('cancellation_requested', fulfillment_order.request_status)
       end
     end
 
@@ -417,17 +430,18 @@ class FulFillmentOrderTest < Test::Unit::TestCase
           fulfillment_order: fulfillment_order.attributes.merge(status: 'cancelled',
                                                                 request_status: 'cancellation_accepted')
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/cancellation_request/accept.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(fake_response)
-
+        )
         accepted = fulfillment_order.accept_cancellation_request(message: message)
 
-        assert_equal true, accepted
-        assert_equal 'cancelled', fulfillment_order.status
-        assert_equal 'cancellation_accepted', fulfillment_order.request_status
+        assert_equal(true, accepted)
+        assert_equal('cancelled', fulfillment_order.status)
+        assert_equal('cancellation_accepted', fulfillment_order.request_status)
       end
     end
 
@@ -445,17 +459,18 @@ class FulFillmentOrderTest < Test::Unit::TestCase
           fulfillment_order: fulfillment_order.attributes.merge(status: 'in_progress',
                                                                 request_status: 'cancellation_rejected')
         }
-        fake 'fulfillment_orders',
+        fake(
+          'fulfillment_orders',
           url: "#{@url_prefix}/fulfillment_orders/519788021/cancellation_request/reject.json",
           method: :post,
           request_body: request_body,
           body: ActiveSupport::JSON.encode(fake_response)
-
+        )
         rejected = fulfillment_order.reject_cancellation_request(message: message)
 
-        assert_equal true, rejected
-        assert_equal 'in_progress', fulfillment_order.status
-        assert_equal 'cancellation_rejected', fulfillment_order.request_status
+        assert_equal(true, rejected)
+        assert_equal('in_progress', fulfillment_order.status)
+        assert_equal('cancellation_rejected', fulfillment_order.request_status)
       end
     end
   end

test/fulfillment_request_test.rb

@@ -13,21 +13,22 @@ class FulFillmentRequestTest < Test::Unit::TestCase
       cancelled = ActiveSupport::JSON.decode(load_fixture('fulfillment_request'))
       cancelled['failure_message'] = 'failure reason'
       cancelled['message'] = nil
-      fake "orders/450789469/fulfillment_requests/695890229/mark_as_failed",
+      fake(
+        "orders/450789469/fulfillment_requests/695890229/mark_as_failed",
         method: :put,
         body: ActiveSupport::JSON.encode(cancelled)
-
-      assert fulfillment_request.failure_message.blank?
-      assert fulfillment_request.mark_as_failed
-      assert_equal 'failure reason', fulfillment_request.failure_message
+      )
+      assert(fulfillment_request.failure_message.blank?)
+      assert(fulfillment_request.mark_as_failed)
+      assert_equal('failure reason', fulfillment_request.failure_message)
     end
   end
 
   context "#find" do
     should "be able to find fulfillment request" do
       fulfillment_request = ShopifyAPI::FulfillmentRequest.find(695890229, params: { order_id: 450789469 })
-      assert_equal 695890229, fulfillment_request.id
-      assert_equal 450789469, fulfillment_request.order_id
+      assert_equal(695890229, fulfillment_request.id)
+      assert_equal(450789469, fulfillment_request.order_id)
     end
   end
 end

test/fulfillment_service_test.rb

@@ -2,16 +2,16 @@ require 'test_helper'
 
 class FulFillmentServiceTest < Test::Unit::TestCase
 	test 'new should create fulfillment service' do
-		fake "fulfillment_services", method: :post, body: load_fixture('fulfillment_service')
+		fake("fulfillment_services", method: :post, body: load_fixture('fulfillment_service'))
 		fulfillment_service = ShopifyAPI::FulfillmentService.new(name: "SomeService")
 		fulfillment_service.save
-		assert_equal "SomeService" , fulfillment_service.name
+		assert_equal("SomeService" , fulfillment_service.name)
 	end
 
 	test 'find should return the fulfillment service' do
-		fake "fulfillment_services/123456", method: :get, body: load_fixture('fulfillment_service')
+		fake("fulfillment_services/123456", method: :get, body: load_fixture('fulfillment_service'))
 		fulfillment_service = ShopifyAPI::FulfillmentService.find(123456)
-		assert_equal 123456 , fulfillment_service.id
-		assert_equal "SomeService", fulfillment_service.name
+		assert_equal(123456 , fulfillment_service.id)
+		assert_equal("SomeService", fulfillment_service.name)
 	end
 end

test/fulfillment_test.rb

@@ -16,11 +16,13 @@ class FulFillmentTest < Test::Unit::TestCase
 
         success = ActiveSupport::JSON.decode(load_fixture('fulfillment'))
         success['fulfillment']['status'] = 'success'
-        fake "orders/450789469/fulfillments/255858046/complete", method: :post, body: ActiveSupport::JSON.encode(success)
+        fake(
+          "orders/450789469/fulfillments/255858046/complete", method: :post, body: ActiveSupport::JSON.encode(success)
+        )
 
-        assert_equal 'pending', fulfillment.status
-        assert fulfillment.complete
-        assert_equal 'success', fulfillment.status
+        assert_equal('pending', fulfillment.status)
+        assert(fulfillment.complete)
+        assert_equal('success', fulfillment.status)
       end
     end
 
@@ -30,11 +32,13 @@ class FulFillmentTest < Test::Unit::TestCase
 
         cancelled = ActiveSupport::JSON.decode(load_fixture('fulfillment'))
         cancelled['fulfillment']['status'] = 'cancelled'
-        fake "orders/450789469/fulfillments/255858046/cancel", method: :post, body: ActiveSupport::JSON.encode(cancelled)
+        fake(
+          "orders/450789469/fulfillments/255858046/cancel", method: :post, body: ActiveSupport::JSON.encode(cancelled)
+        )
 
-        assert_equal 'pending', fulfillment.status
-        assert fulfillment.cancel
-        assert_equal 'cancelled', fulfillment.status
+        assert_equal('pending', fulfillment.status)
+        assert(fulfillment.cancel)
+        assert_equal('cancelled', fulfillment.status)
       end
     end
 
@@ -44,19 +48,23 @@ class FulFillmentTest < Test::Unit::TestCase
 
         open_fulfillment = ActiveSupport::JSON.decode(load_fixture('fulfillment'))
         open_fulfillment['fulfillment']['status'] = 'open'
-        fake "orders/450789469/fulfillments/255858046/open", method: :post, body: ActiveSupport::JSON.encode(open_fulfillment)
+        fake(
+          "orders/450789469/fulfillments/255858046/open",
+          method: :post,
+          body: ActiveSupport::JSON.encode(open_fulfillment)
+        )
 
-        assert_equal 'pending', fulfillment.status
-        assert fulfillment.open
-        assert_equal 'open', fulfillment.status
+        assert_equal('pending', fulfillment.status)
+        assert(fulfillment.open)
+        assert_equal('open', fulfillment.status)
       end
     end
 
     context "#find" do
       should "be able to find fulfillment" do
         fulfillment = ShopifyAPI::Fulfillment.find(255858046, params: { order_id: 450789469 })
-        assert_equal 255858046, fulfillment.id
-        assert_equal 450789469, fulfillment.order_id
+        assert_equal(255858046, fulfillment.id)
+        assert_equal(450789469, fulfillment.order_id)
       end
     end
 
@@ -80,16 +88,17 @@ class FulFillmentTest < Test::Unit::TestCase
         request_body = { fulfillment: create_fulfillment_attributes }
         response_body = { fulfillment: create_fulfillment_attributes.merge(id: 346743624) }
         url_prefix = url_prefix_for_activated_session_for('2020-01')
-        fake 'fulfillments',
+        fake(
+          'fulfillments',
           url: "#{url_prefix}/fulfillments.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(response_body)
-
+        )
         fulfillment = ShopifyAPI::Fulfillment.create(create_fulfillment_attributes)
-        assert fulfillment.is_a?(ShopifyAPI::Fulfillment)
-        assert fulfillment.persisted?
-        assert_equal 346743624, fulfillment.id
+        assert(fulfillment.is_a?(ShopifyAPI::Fulfillment))
+        assert(fulfillment.persisted?)
+        assert_equal(346743624, fulfillment.id)
       end
 
       should "raise NotImplementedError when api_version is older than 2020-01" do
@@ -111,13 +120,14 @@ class FulFillmentTest < Test::Unit::TestCase
         request_body = { fulfillment: create_fulfillment_attributes }
         response_body = { fulfillment: create_fulfillment_attributes.merge(id: 346743624) }
         url_prefix = url_prefix_for_activated_session_for('2019-10')
-        fake 'fulfillments',
+        fake(
+          'fulfillments',
           url: "#{url_prefix}/fulfillments.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(response_body)
-
-        assert_raises NotImplementedError do
+        )
+        assert_raises(NotImplementedError) do
           ShopifyAPI::Fulfillment.create(create_fulfillment_attributes)
         end
       end
@@ -143,17 +153,18 @@ class FulFillmentTest < Test::Unit::TestCase
         request_body = { fulfillment: create_fulfillment_attributes }
         response_body = { fulfillment: create_fulfillment_attributes.merge(id: 346743624) }
         url_prefix = url_prefix_for_activated_session_for('2020-01')
-        fake 'fulfillments',
+        fake(
+          'fulfillments',
           url: "#{url_prefix}/fulfillments.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(response_body)
-
+        )
         fulfillment = ShopifyAPI::Fulfillment.new(create_fulfillment_attributes)
-        assert fulfillment.save
-        assert fulfillment.is_a?(ShopifyAPI::Fulfillment)
-        assert fulfillment.persisted?
-        assert_equal 346743624, fulfillment.id
+        assert(fulfillment.save)
+        assert(fulfillment.is_a?(ShopifyAPI::Fulfillment))
+        assert(fulfillment.persisted?)
+        assert_equal(346743624, fulfillment.id)
       end
 
       should "save a fulfillment without line_items_by_fulfillment_order" do
@@ -169,17 +180,19 @@ class FulFillmentTest < Test::Unit::TestCase
         }
         request_body = { fulfillment: create_fulfillment_attributes }
         response_body = { fulfillment: create_fulfillment_attributes.merge(id: 346743624) }
-        fake "orders/#{order_id}/fulfillments", method: :post,
+        fake(
+          "orders/#{order_id}/fulfillments",
+          method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(response_body)
-
+        )
         fulfillment = ShopifyAPI::Fulfillment.new(create_fulfillment_attributes)
         fulfillment.prefix_options[:order_id] = order_id
 
-        assert fulfillment.save
-        assert fulfillment.is_a?(ShopifyAPI::Fulfillment)
-        assert fulfillment.persisted?
-        assert_equal 346743624, fulfillment.id
+        assert(fulfillment.save)
+        assert(fulfillment.is_a?(ShopifyAPI::Fulfillment))
+        assert(fulfillment.persisted?)
+        assert_equal(346743624, fulfillment.id)
       end
     end
 
@@ -204,20 +217,21 @@ class FulFillmentTest < Test::Unit::TestCase
           }
         }
         url_prefix = url_prefix_for_activated_session_for('2020-01')
-        fake 'fulfillments',
+        fake(
+          'fulfillments',
           url: "#{url_prefix}/fulfillments/#{fake_fulfillment['id']}/update_tracking.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(request_body),
           body: ActiveSupport::JSON.encode(fulfillment: fake_fulfillment)
-
+        )
         fulfillment = ShopifyAPI::Fulfillment.new(id: fake_fulfillment['id'])
-        assert fulfillment.update_tracking(tracking_info: tracking_info, notify_customer: true)
+        assert(fulfillment.update_tracking(tracking_info: tracking_info, notify_customer: true))
 
-        assert_equal tracking_info[:number], fulfillment.tracking_number
-        assert_equal [tracking_info[:number]], fulfillment.tracking_numbers
-        assert_equal tracking_info[:url], fulfillment.tracking_url
-        assert_equal [tracking_info[:url]], fulfillment.tracking_urls
-        assert_equal tracking_info[:company], fulfillment.tracking_company
+        assert_equal(tracking_info[:number], fulfillment.tracking_number)
+        assert_equal([tracking_info[:number]], fulfillment.tracking_numbers)
+        assert_equal(tracking_info[:url], fulfillment.tracking_url)
+        assert_equal([tracking_info[:url]], fulfillment.tracking_urls)
+        assert_equal(tracking_info[:company], fulfillment.tracking_company)
       end
     end
   end

test/fulfillment_v2_test.rb

@@ -25,35 +25,38 @@ class FulfillmentV2Test < Test::Unit::TestCase
       }
     }
     @url_prefix = url_prefix_for_activated_session_for('2020-01')
-    fake('fulfillments',
+    fake(
+      'fulfillments',
       url: "#{@url_prefix}/fulfillments/#{@fake_fulfillment['id']}/update_tracking.json",
       method: :post,
       request_body: ActiveSupport::JSON.encode(@request_body),
-      body: ActiveSupport::JSON.encode(fulfillment: @fake_fulfillment))
+      body: ActiveSupport::JSON.encode(fulfillment: @fake_fulfillment)
+    )
   end
 
   context "FulfillmentV2" do
     context "#update_tracking" do
       should "be able to update tracking info for a fulfillment" do
         fulfillment = ShopifyAPI::FulfillmentV2.new(id: @fake_fulfillment['id'])
-        assert fulfillment.update_tracking(tracking_info: @tracking_info, notify_customer: true)
+        assert(fulfillment.update_tracking(tracking_info: @tracking_info, notify_customer: true))
 
-        assert_equal @tracking_info[:number], fulfillment.tracking_number
-        assert_equal [@tracking_info[:number]], fulfillment.tracking_numbers
-        assert_equal @tracking_info[:url], fulfillment.tracking_url
-        assert_equal [@tracking_info[:url]], fulfillment.tracking_urls
-        assert_equal @tracking_info[:company], fulfillment.tracking_company
+        assert_equal(@tracking_info[:number], fulfillment.tracking_number)
+        assert_equal([@tracking_info[:number]], fulfillment.tracking_numbers)
+        assert_equal(@tracking_info[:url], fulfillment.tracking_url)
+        assert_equal([@tracking_info[:url]], fulfillment.tracking_urls)
+        assert_equal(@tracking_info[:company], fulfillment.tracking_company)
       end
 
       should "raise NotImplementedError when api_version is older than 2020-01" do
         @url_prefix = url_prefix_for_activated_session_for('2019-10')
-        fake 'fulfillments',
+        fake(
+          'fulfillments',
           url: "#{@url_prefix}/fulfillments/#{@fake_fulfillment['id']}/update_tracking.json",
           method: :post,
           request_body: ActiveSupport::JSON.encode(@request_body),
           body: ActiveSupport::JSON.encode(fulfillment: @fake_fulfillment)
-
-        assert_raises NotImplementedError do
+        )
+        assert_raises(NotImplementedError) do
           ShopifyAPI::FulfillmentV2.new(id: @fake_fulfillment['id'])
         end
       end

test/graphql_test.rb

@@ -18,7 +18,7 @@ class GraphQLTest < Test::Unit::TestCase
     version_fixtures('unstable') do |_dir|
       ShopifyAPI::GraphQL.initialize_clients
 
-      assert ShopifyAPI::GraphQL.client('unstable')
+      assert(ShopifyAPI::GraphQL.client('unstable'))
     end
   end
 
@@ -26,8 +26,8 @@ class GraphQLTest < Test::Unit::TestCase
     version_fixtures('unstable', '2019-10') do |_dir|
       ShopifyAPI::GraphQL.initialize_clients
 
-      assert ShopifyAPI::GraphQL.client('unstable')
-      assert ShopifyAPI::GraphQL.client('2019-10')
+      assert(ShopifyAPI::GraphQL.client('unstable'))
+      assert(ShopifyAPI::GraphQL.client('2019-10'))
     end
   end
 
@@ -37,8 +37,8 @@ class GraphQLTest < Test::Unit::TestCase
 
       ShopifyAPI::GraphQL.initialize_clients
 
-      assert ShopifyAPI::GraphQL.client('unstable')
-      assert ShopifyAPI::GraphQL.client('2019-10')
+      assert(ShopifyAPI::GraphQL.client('unstable'))
+      assert(ShopifyAPI::GraphQL.client('2019-10'))
     end
   end
 
@@ -47,7 +47,7 @@ class GraphQLTest < Test::Unit::TestCase
       ShopifyAPI::GraphQL.schema_location = dir
       FileUtils.touch(ShopifyAPI::GraphQL.schema_location.join('nope.json'))
 
-      assert_raises ShopifyAPI::GraphQL::InvalidSchema do
+      assert_raises(ShopifyAPI::GraphQL::InvalidSchema) do
         ShopifyAPI::GraphQL.initialize_clients
       end
     end
@@ -60,7 +60,7 @@ class GraphQLTest < Test::Unit::TestCase
 
       ShopifyAPI::GraphQL.initialize_clients(raise_on_invalid_schema: false)
 
-      assert ShopifyAPI::GraphQL.client('unstable')
+      assert(ShopifyAPI::GraphQL.client('unstable'))
     end
   end
 
@@ -70,7 +70,7 @@ class GraphQLTest < Test::Unit::TestCase
 
       ShopifyAPI::GraphQL.initialize_clients
 
-      assert_instance_of ::GraphQL::Client, ShopifyAPI::GraphQL.client
+      assert_instance_of(::GraphQL::Client, ShopifyAPI::GraphQL.client)
     end
   end
 
@@ -80,7 +80,7 @@ class GraphQLTest < Test::Unit::TestCase
 
       ShopifyAPI::GraphQL.initialize_clients
 
-      assert_instance_of ::GraphQL::Client, ShopifyAPI::GraphQL.client('unstable')
+      assert_instance_of(::GraphQL::Client, ShopifyAPI::GraphQL.client('unstable'))
     end
   end
 
@@ -93,7 +93,7 @@ class GraphQLTest < Test::Unit::TestCase
 
       client = ShopifyAPI::GraphQL.client('2019-10')
 
-      assert_instance_of ::GraphQL::Client, client
+      assert_instance_of(::GraphQL::Client, client)
 
       query = client.parse(<<~GRAPHQL)
         {
@@ -116,7 +116,7 @@ class GraphQLTest < Test::Unit::TestCase
 
       ShopifyAPI::GraphQL.initialize_clients
 
-      assert_raises ShopifyAPI::GraphQL::InvalidClient do
+      assert_raises(ShopifyAPI::GraphQL::InvalidClient) do
         ShopifyAPI::GraphQL.client('2019-10')
       end
     end
@@ -126,7 +126,7 @@ class GraphQLTest < Test::Unit::TestCase
     version_fixtures('unstable') do |_dir|
       ShopifyAPI::Base.api_version = 'unstable'
 
-      assert_raises ShopifyAPI::GraphQL::InvalidClient do
+      assert_raises(ShopifyAPI::GraphQL::InvalidClient) do
         ShopifyAPI::GraphQL.client('2019-10')
       end
     end
@@ -139,7 +139,7 @@ class GraphQLTest < Test::Unit::TestCase
       client1 = ShopifyAPI::GraphQL.client
       client2 = ShopifyAPI::GraphQL.client('unstable')
 
-      assert_equal client1, client2
+      assert_equal(client1, client2)
     end
   end
 
@@ -152,7 +152,7 @@ class GraphQLTest < Test::Unit::TestCase
       ShopifyAPI::Base.api_version = 'unstable'
 
       ShopifyAPI::GraphQL.initialize_clients
-      assert_instance_of SuperDuperExecutionAdapter, ShopifyAPI::GraphQL.client('unstable').execute
+      assert_instance_of(SuperDuperExecutionAdapter, ShopifyAPI::GraphQL.client('unstable').execute)
     end
 
     ShopifyAPI::GraphQL.execution_adapter = nil
@@ -168,7 +168,7 @@ class GraphQLTest < Test::Unit::TestCase
 
       ShopifyAPI::GraphQL.initialize_clients
 
-      assert_instance_of SuperDuperClient, ShopifyAPI::GraphQL.client('unstable')
+      assert_instance_of(SuperDuperClient, ShopifyAPI::GraphQL.client('unstable'))
     end
 
     ShopifyAPI::GraphQL.clear_clients

test/image_test.rb

@@ -5,7 +5,8 @@ class ImageTest < Test::Unit::TestCase
     fake("products/632910392/images", method: :post, body: load_fixture('image'))
     image = ShopifyAPI::Image.new(product_id: 632910392)
     image.position = 1
-    image.attachment = "R0lGODlhbgCMAPf/APbr48VySrxTO7IgKt2qmKQdJeK8lsFjROG5p/nz7Zg3MNmnd7Q1MLNVS9GId71hSJMZIuzTu4UtKbeEeakhKMl8U8WYjfr18YQaIbAf=="
+    image.attachment = "R0lGODlhbgCMAPf/APbr48VySrxTO7IgKt2qmKQdJeK8lsFjROG5p/nz7Zg3MN" \
+      "mnd7Q1MLNVS9GId71hSJMZIuzTu4UtKbeEeakhKMl8U8WYjfr18YQaIbAf=="
     image.save
 
     assert_equal('http://cdn.shopify.com/s/files/1/0006/9093/3842/products/ipod-nano.png?v=1389388540', image.src)

test/inventory_level_test.rb

@@ -9,14 +9,22 @@ class InventoryLevelTest < Test::Unit::TestCase
 
   test ".find with inventory_item_ids and location_ids returns expected inventory levels" do
     params = { inventory_item_ids: [808950810, 39072856], location_ids: [905684977, 487838322] }
-    fake "inventory_levels.json?#{params.to_param}", extension: false, method: :get,
-          status: 200, body: load_fixture('inventory_levels')
+    fake(
+      "inventory_levels.json?#{params.to_param}",
+      extension: false,
+      method: :get,
+      status: 200,
+      body: load_fixture('inventory_levels')
+    )
     inventory_levels = ShopifyAPI::InventoryLevel.find(:all, params: params)
 
-    assert inventory_levels.all? { |item|
-      params[:location_ids].include?(item.location_id) &&
-      params[:inventory_item_ids].include?(item.inventory_item_id)
-    }, message: 'Response contained inventory_items or locations not requested.'
+    assert(
+      inventory_levels.all? { |item|
+        params[:location_ids].include?(item.location_id) &&
+        params[:inventory_item_ids].include?(item.inventory_item_id)
+      },
+      message: 'Response contained inventory_items or locations not requested.'
+    )
   end
 
   test '#adjust with adjustment value returns inventory_level with available increased by adjustment value' do
@@ -24,9 +32,9 @@ class InventoryLevelTest < Test::Unit::TestCase
     updated_available = @inventory_level.available + adjustment
     @inventory_level_response[:available] = updated_available
 
-    fake 'inventory_levels/adjust', method: :post, body: ActiveSupport::JSON.encode(@inventory_level_response)
+    fake('inventory_levels/adjust', method: :post, body: ActiveSupport::JSON.encode(@inventory_level_response))
     @inventory_level.adjust(adjustment)
-    assert_equal updated_available, @inventory_level.available
+    assert_equal(updated_available, @inventory_level.available)
   end
 
   test '#connect saves an inventory_level associated with inventory_item and location_id' do
@@ -34,16 +42,16 @@ class InventoryLevelTest < Test::Unit::TestCase
     response = params.clone
     response[:available] = 0
 
-    fake 'inventory_levels/connect', method: :post, body: ActiveSupport::JSON.encode(response)
+    fake('inventory_levels/connect', method: :post, body: ActiveSupport::JSON.encode(response))
     inventory_level = ShopifyAPI::InventoryLevel.new(params)
     inventory_level.connect
-    assert_equal 0, inventory_level.available, message: 'expected newly connected location to have 0 inventory'
+    assert_equal(0, inventory_level.available, message: 'expected newly connected location to have 0 inventory')
   end
 
   test '#destroy removes inventory_level and returns nil' do
     params = { inventory_item_id: @inventory_level.inventory_item_id, location_id: @inventory_level.location_id }
-    fake "inventory_levels.json?#{params.to_param}", extension: false, method: :delete, status: 204, body: nil
-    assert_nil @inventory_level.destroy
+    fake("inventory_levels.json?#{params.to_param}", extension: false, method: :delete, status: 204, body: nil)
+    assert_nil(@inventory_level.destroy)
   end
 
   test '#set with available value returns inventory_level with available as the available value' do
@@ -51,9 +59,9 @@ class InventoryLevelTest < Test::Unit::TestCase
     response = @inventory_level_response.clone
     response['inventory_level']['available'] = available
 
-    fake 'inventory_levels/set', method: :post, body: ActiveSupport::JSON.encode(response)
+    fake('inventory_levels/set', method: :post, body: ActiveSupport::JSON.encode(response))
     @inventory_level.set(available)
 
-    assert_equal available, @inventory_level.available
+    assert_equal(available, @inventory_level.available)
   end
 end

test/limits_test.rb

@@ -30,7 +30,7 @@ class LimitsTest < Test::Unit::TestCase
     should "raise error when header doesn't exist" do
       @header_hash = {}
       ShopifyAPI::Base.connection.expects(:response).at_least(1).returns(@header_hash)
-      assert_raises ShopifyAPI::Limits::LimitUnavailable do
+      assert_raises(ShopifyAPI::Limits::LimitUnavailable) do
         ShopifyAPI.credit_left
       end
     end

test/metafield_test.rb

@@ -22,9 +22,19 @@ class MetafieldTest < Test::Unit::TestCase
     fake("blogs/1008414260/metafields", method: :post, status: 201, body: load_fixture('metafield'))
 
     blog = ShopifyAPI::Blog.find(1008414260)
-    metafield = blog.add_metafield(ShopifyAPI::Metafield.new(namespace: "summaries", key: "First Summary", value: "Make commerce better", value_type: "string"))
-
-    assert_equal(ActiveSupport::JSON.decode('{"metafield":{"namespace":"summaries","key":"First Summary","value":"Make commerce better","value_type":"string"}}'), ActiveSupport::JSON.decode(WebMock.last_request.body))
+    metafield = blog.add_metafield(
+      ShopifyAPI::Metafield.new(
+        namespace: "summaries", key: "First Summary", value: "Make commerce better", value_type: "string"
+      )
+    )
+
+    assert_equal(
+      ActiveSupport::JSON.decode(
+        '{"metafield":{"namespace":"summaries","key":"First Summary",' \
+          '"value":"Make commerce better","value_type":"string"}}'
+      ),
+      ActiveSupport::JSON.decode(WebMock.last_request.body)
+    )
     assert(!metafield.new_record?)
   end
 

test/order_test.rb

@@ -5,65 +5,75 @@ class OrderTest < Test::Unit::TestCase
   include FulfillmentOrderTestHelper
 
   test "create should create order" do
-    fake 'orders', method: :post, status: 201, body: load_fixture('order')
+    fake('orders', method: :post, status: 201, body: load_fixture('order'))
     order = ShopifyAPI::Order.create(line_items: [{ quantity:1, variant_id:39072856 }], financial_status:"authorized")
-    assert_equal 39072856, order.line_items.first.variant_id
+    assert_equal(39072856, order.line_items.first.variant_id)
   end
 
   test "create should create an order with custom properties" do
-    props = [{ "By default may label with \"Roasted for ": { "Your First Name": { "\". If you want something specific on the label, enter it here:": "" } } }]
-    fake 'orders', method: :post, status: 201, body: load_fixture('order_with_properties')
-    order = ShopifyAPI::Order.create(line_items: [{ quantity:1, variant_id:39072856, properties:props }], financial_status:"authorized")
-    assert_equal 39072856, order.line_items.first.variant_id
+    props = [
+      {
+        "By default may label with \"Roasted for ": {
+          "Your First Name": {
+            "\". If you want something specific on the label, enter it here:": "",
+          },
+        },
+      },
+    ]
+    fake('orders', method: :post, status: 201, body: load_fixture('order_with_properties'))
+    order = ShopifyAPI::Order.create(
+      line_items: [{ quantity:1, variant_id:39072856, properties:props }], financial_status:"authorized"
+    )
+    assert_equal(39072856, order.line_items.first.variant_id)
   end
 
   test "get should get an order" do
-    fake 'orders/450789469', method: :get, status: 200, body: load_fixture('order')
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order'))
     order = ShopifyAPI::Order.find(450789469)
-    assert_equal 450789469, order.id
+    assert_equal(450789469, order.id)
   end
 
   test "get should get an order with custom properties" do
-    fake 'orders/450789469', method: :get, status: 200, body: load_fixture('order_with_properties')
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order_with_properties'))
     order = ShopifyAPI::Order.find(450789469)
-    assert_equal 450789469, order.id
+    assert_equal(450789469, order.id)
   end
 
   test "get all should get all orders" do
-    fake 'orders', method: :get, status: 200, body: load_fixture('orders')
+    fake('orders', method: :get, status: 200, body: load_fixture('orders'))
     order = ShopifyAPI::Order.all
-    assert_equal 450789469, order.first.id
+    assert_equal(450789469, order.first.id)
   end
 
   test "add note should add a note to order" do
-    fake 'orders/450789469', method: :get, status: 200, body: load_fixture('order')
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order'))
     order = ShopifyAPI::Order.find(450789469)
     order.note = "Test note"
-    fake 'orders/450789469', method: :put, status: 200, body: load_fixture('order')
+    fake('orders/450789469', method: :put, status: 200, body: load_fixture('order'))
     order.save
-    assert_equal "Test note", order.note
+    assert_equal("Test note", order.note)
   end
 
   test "delete should delete an order" do
-    fake 'orders/450789469', method: :get, status: 200, body: load_fixture('order')
-    fake 'orders/450789469', method: :delete, body: 'destroyed'
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order'))
+    fake('orders/450789469', method: :delete, body: 'destroyed')
     order = ShopifyAPI::Order.find(450789469)
-    assert order.destroy
+    assert(order.destroy)
   end
 
   test "cancel an order with params" do
-    fake 'orders/450789469', method: :get, status: 200, body: load_fixture('order')
-    fake 'orders/450789469/cancel', method: :post, body: load_fixture('order')
+    fake('orders/450789469', method: :get, status: 200, body: load_fixture('order'))
+    fake('orders/450789469/cancel', method: :post, body: load_fixture('order'))
     order = ShopifyAPI::Order.find(450789469)
     order.cancel(email: false, restock: true)
     assert_request_body({ 'email' => false, 'restock' => true }.to_json)
   end
 
   test "capture an order with currency param" do
-    fake 'orders/450789469', body: load_fixture('order')
+    fake('orders/450789469', body: load_fixture('order'))
     order = ShopifyAPI::Order.find(450789469)
 
-    fake 'orders/450789469/transactions', method: :post, status: 201, body: load_fixture('transaction')
+    fake('orders/450789469/transactions', method: :post, status: 201, body: load_fixture('transaction'))
     order.capture(100.00, currency: 'CAD')
 
     assert_request_body({
@@ -98,10 +108,10 @@ class OrderTest < Test::Unit::TestCase
     )
     fulfillment_orders = order.fulfillment_orders
 
-    assert_equal [519788021, 519788022], fulfillment_orders.map(&:id).sort
+    assert_equal([519788021, 519788022], fulfillment_orders.map(&:id).sort)
     fulfillment_orders.each do |fulfillment_order|
-      assert fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder)
-      assert_equal 450789469, fulfillment_order.order_id
+      assert(fulfillment_order.is_a?(ShopifyAPI::FulfillmentOrder))
+      assert_equal(450789469, fulfillment_order.order_id)
     end
   end
 
@@ -118,7 +128,7 @@ class OrderTest < Test::Unit::TestCase
     )
     order = ShopifyAPI::Order.find(450789469)
 
-    assert_raises NotImplementedError do
+    assert_raises(NotImplementedError) do
       order.fulfillment_orders
     end
   end

test/pagination_test.rb

@@ -9,14 +9,16 @@ class PaginationTest < Test::Unit::TestCase
     @next_page_info = "eyJkaXJlY3Rpb24iOiJuZXh0IiwibGFzdF9pZCI6NDQwMDg5NDIzLCJsYXN0X3ZhbHVlIjoiNDQwMDg5NDIzIn0%3D"
     @previous_page_info = "eyJsYXN0X2lkIjoxMDg4MjgzMDksImxhc3RfdmFsdWUiOiIxMDg4MjgzMDkiLCJkaXJlY3Rpb24iOiJuZXh0In0%3D"
 
-    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?page_info=#{@next_page_info}>; rel=\"next\""
-    @previous_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?page_info=#{@previous_page_info}>; rel=\"previous\""
+    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+      "orders.json?page_info=#{@next_page_info}>; rel=\"next\""
+    @previous_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+      "orders.json?page_info=#{@previous_page_info}>; rel=\"previous\""
   end
 
   test "navigates using next and previous link headers with no original params" do
     link_header ="#{@previous_link_header}, #{@next_link_header}"
 
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: link_header
+    fake('orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: link_header)
     orders = ShopifyAPI::Order.all
 
     fake(
@@ -27,7 +29,7 @@ class PaginationTest < Test::Unit::TestCase
       body: load_fixture('orders')
     )
     next_page = orders.fetch_next_page
-    assert_equal 450789469, next_page.first.id
+    assert_equal(450789469, next_page.first.id)
 
     fake(
       'orders',
@@ -38,12 +40,13 @@ class PaginationTest < Test::Unit::TestCase
     )
 
     previous_page = orders.fetch_previous_page
-    assert_equal 1122334455, previous_page.first.id
+    assert_equal(1122334455, previous_page.first.id)
   end
 
   test "uses all passed in querystring parameters" do
     params = "page_info=#{@next_page_info}&limit=50&fields=#{CGI.escape('id,created_at')}"
-    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?#{params}>; rel=\"next\""
+    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+      "orders.json?#{params}>; rel=\"next\""
     fake(
       'orders',
       method: :get,
@@ -60,100 +63,127 @@ class PaginationTest < Test::Unit::TestCase
       method: :get,
       status: 200,
       api_version: @version,
-      url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?fields=id%2Ccreated_at&limit=50&page_info=#{@next_page_info}",
+      url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+        "orders.json?fields=id%2Ccreated_at&limit=50&page_info=#{@next_page_info}",
       body: load_fixture('orders')
     )
     next_page = orders.fetch_next_page
-    assert_equal 450789469, next_page.first.id
+    assert_equal(450789469, next_page.first.id)
   end
 
   test "returns empty next page if just the previous page is present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
     next_page = orders.fetch_next_page
-    assert_empty next_page
+    assert_empty(next_page)
   end
 
   test "returns an empty previous page if just the next page is present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
     next_page = orders.fetch_previous_page
-    assert_empty next_page
+    assert_empty(next_page)
   end
 
   test "#next_page? returns true if next page is present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert orders.next_page?
+    assert(orders.next_page?)
   end
 
   test "#next_page? returns false if next page is not present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    refute orders.next_page?
+    refute(orders.next_page?)
   end
 
   test "#next_page_info returns next_page_info if next page is present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert_equal @next_page_info, orders.next_page_info
+    assert_equal(@next_page_info, orders.next_page_info)
   end
 
   test "#next_page_info returns nil if next page is not present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert_nil orders.next_page_info
+    assert_nil(orders.next_page_info)
   end
 
   test "#previous_page? returns true if previous page is present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert orders.previous_page?
+    assert(orders.previous_page?)
   end
 
   test "#previous_page? returns false if next page is not present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    refute orders.previous_page?
+    refute(orders.previous_page?)
   end
 
   test "#previous_page_info returns previous_page_info if next page is present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @previous_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version,
+      body: load_fixture('orders'), link: @previous_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert_equal @previous_page_info, orders.previous_page_info
+    assert_equal(@previous_page_info, orders.previous_page_info)
   end
 
   test "#previous_page_info returns nil if next page is not present" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    fake(
+      'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: @next_link_header
+    )
     orders = ShopifyAPI::Order.all
 
-    assert_nil orders.previous_page_info
+    assert_nil(orders.previous_page_info)
   end
 
   test "pagination handles no link headers" do
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders')
+    fake('orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'))
     orders = ShopifyAPI::Order.all
 
-    refute orders.next_page?
-    refute orders.previous_page?
-    assert_empty orders.fetch_next_page
-    assert_empty orders.fetch_previous_page
+    refute(orders.next_page?)
+    refute(orders.previous_page?)
+    assert_empty(orders.fetch_next_page)
+    assert_empty(orders.fetch_previous_page)
   end
 
   test "raises on invalid pagination links" do
-    link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?page_info=#{@next_page_info}>;"
-    fake 'orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: link_header
+    link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+      "orders.json?page_info=#{@next_page_info}>;"
+    fake('orders', method: :get, status: 200, api_version: @version, body: load_fixture('orders'), link: link_header)
 
-    assert_raises ShopifyAPI::InvalidPaginationLinksError do
+    assert_raises(ShopifyAPI::InvalidPaginationLinksError) do
       ShopifyAPI::Order.all
     end
   end
@@ -162,10 +192,10 @@ class PaginationTest < Test::Unit::TestCase
     version = ShopifyAPI::ApiVersion.find_version('2019-04')
     ShopifyAPI::Base.api_version = version.to_s
 
-    fake 'orders', method: :get, status: 200, api_version: version, body: load_fixture('orders')
+    fake('orders', method: :get, status: 200, api_version: version, body: load_fixture('orders'))
     orders = ShopifyAPI::Order.all
 
-    assert_raises NotImplementedError do
+    assert_raises(NotImplementedError) do
       orders.fetch_next_page
     end
   end
@@ -174,10 +204,10 @@ class PaginationTest < Test::Unit::TestCase
     version = ShopifyAPI::ApiVersion.find_version('2019-07')
     ShopifyAPI::Base.api_version = version.to_s
 
-    fake 'orders', method: :get, status: 200, api_version: version, body: load_fixture('orders')
+    fake('orders', method: :get, status: 200, api_version: version, body: load_fixture('orders'))
     orders = ShopifyAPI::Order.all
 
-    assert_raises NotImplementedError do
+    assert_raises(NotImplementedError) do
       orders.fetch_next_page
     end
   end
@@ -186,21 +216,22 @@ class PaginationTest < Test::Unit::TestCase
     version = ShopifyAPI::ApiVersion.find_version('2019-07')
     ShopifyAPI::Base.api_version = version.to_s
 
-    fake 'events', method: :get, status: 200, api_version: version, body: load_fixture('events')
+    fake('events', method: :get, status: 200, api_version: version, body: load_fixture('events'))
     events = ShopifyAPI::Event.all
 
-    assert_empty events.fetch_next_page
-    assert_empty events.fetch_previous_page
+    assert_empty(events.fetch_next_page)
+    assert_empty(events.fetch_previous_page)
   end
 
   test "does not raise on the unstable version" do
     version = ShopifyAPI::ApiVersion.find_version('unstable')
     ShopifyAPI::Base.api_version = version.to_s
-    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/unstable/orders.json?page_info=#{@next_page_info}>; rel=\"next\""
+    @next_link_header = "<https://this-is-my-test-shop.myshopify.com/admin/api/unstable/" \
+      "orders.json?page_info=#{@next_page_info}>; rel=\"next\""
 
     link_header ="#{@previous_link_header}, #{@next_link_header}"
 
-    fake 'orders', method: :get, status: 200, api_version: version, body: load_fixture('orders'), link: link_header
+    fake('orders', method: :get, status: 200, api_version: version, body: load_fixture('orders'), link: link_header)
     orders = ShopifyAPI::Order.all
 
     fake(
@@ -212,7 +243,7 @@ class PaginationTest < Test::Unit::TestCase
     )
     assert_nothing_raised do
       next_page = orders.fetch_next_page
-      assert_equal 450789469, next_page.first.id
+      assert_equal(450789469, next_page.first.id)
     end
   end
 
@@ -225,7 +256,8 @@ class PaginationTest < Test::Unit::TestCase
       api_version: @version,
       url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?limit=5",
       body: load_fixture('orders'),
-      link: "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?#{first_request_params}>; rel=\"next\""
+      link: "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+        "orders.json?#{first_request_params}>; rel=\"next\""
     )
     ShopifyAPI::Order.where(limit: 5)
 
@@ -237,7 +269,8 @@ class PaginationTest < Test::Unit::TestCase
       api_version: @version,
       url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?limit=10",
       body: load_fixture('orders'),
-      link: "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?#{second_request_params}>; rel=\"next\""
+      link: "<https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+        "orders.json?#{second_request_params}>; rel=\"next\""
     )
     orders = ShopifyAPI::Order.where(limit: 10)
 
@@ -246,11 +279,12 @@ class PaginationTest < Test::Unit::TestCase
       method: :get,
       status: 200,
       api_version: @version,
-      url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/orders.json?limit=5&page_info=#{@next_page_info}",
+      url: "https://this-is-my-test-shop.myshopify.com/admin/api/2019-10/" \
+        "orders.json?limit=5&page_info=#{@next_page_info}",
       body: load_fixture('orders')
     )
     next_page = orders.fetch_next_page
-    assert_equal 450789469, next_page.first.id
+    assert_equal(450789469, next_page.first.id)
   end
 
 end

test/price_rule_test.rb

@@ -42,7 +42,11 @@ class PriceRuleTest < Test::Unit::TestCase
       starts_at: "2017-01-19T00:00:00Z"
     )
 
-    assert_equal('{"price_rule":{"target_type":"line_item","allocation_method":"across","value_type":"fixed_amount","value":-10.0,"customer_selection":"all","starts_at":"2017-01-19T00:00:00Z"}}', WebMock.last_request.body)
+    assert_equal(
+      '{"price_rule":{"target_type":"line_item","allocation_method":"across","value_type":"fixed_amount",' \
+        '"value":-10.0,"customer_selection":"all","starts_at":"2017-01-19T00:00:00Z"}}',
+      WebMock.last_request.body
+    )
     assert_equal(-10, price_rule.value)
   end
 

test/product_test.rb

@@ -10,8 +10,15 @@ class ProductTest < Test::Unit::TestCase
   def test_add_metafields_to_product
     fake("products/632910392/metafields", method: :post, status: 201, body: load_fixture('metafield'))
 
-    field = @product.add_metafield(ShopifyAPI::Metafield.new(namespace: "contact", key: "email", value: "123@example.com", value_type: "string"))
-    assert_equal(ActiveSupport::JSON.decode('{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'), ActiveSupport::JSON.decode(WebMock.last_request.body))
+    field = @product.add_metafield(
+      ShopifyAPI::Metafield.new(namespace: "contact", key: "email", value: "123@example.com", value_type: "string")
+    )
+    assert_equal(
+      ActiveSupport::JSON.decode(
+        '{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'
+      ),
+      ActiveSupport::JSON.decode(WebMock.last_request.body)
+    )
     assert(!field.new_record?)
     assert_equal("contact", field.namespace)
     assert_equal("email", field.key)

test/recurring_application_charge_test.rb

@@ -3,7 +3,9 @@ require 'test_helper'
 class RecurringApplicationChargeTest < Test::Unit::TestCase
 
   def test_recurring_application_charges_create
-    fake("recurring_application_charges", method: :post, status: 201, body: load_fixture('recurring_application_charge'))
+    fake(
+      "recurring_application_charges", method: :post, status: 201, body: load_fixture('recurring_application_charge')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.create(
       name: "Default Plan",
@@ -11,11 +13,20 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
       return_url: "http://test.com/confirm"
     )
 
-    assert_equal('http://apple.myshopify.com/admin/charges/654381177/confirm_recurring_application_charge?signature=BAhpBHkQASc%3D--419fc7424f8c290ac2b21b9004ed223e35b52164', charge.confirmation_url)
+    assert_equal(
+      'http://apple.myshopify.com/admin/charges/654381177/confirm_recurring_application_charge?' \
+        'signature=BAhpBHkQASc%3D--419fc7424f8c290ac2b21b9004ed223e35b52164',
+      charge.confirmation_url
+      )
   end
 
   def test_get_recurring_application_charges
-    fake("recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge'))
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
 
@@ -23,7 +34,9 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_list_recurring_application_charges
-    fake("recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all)
 
@@ -31,7 +44,13 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_list_since_recurring_application_charges
-    fake("recurring_application_charges.json?since_id=64512345",extension: false, method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges.json?since_id=64512345",
+      extension: false,
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all, params: { since_id: '64512345' })
 
@@ -39,7 +58,13 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_list_fields_recurring_application_charges
-    fake("recurring_application_charges.json?fields=name",extension: false, method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges.json?fields=name",
+      extension: false,
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(:all, params: { fields: 'name' })
 
@@ -47,7 +72,9 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_pending_recurring_application_charge
-    fake("recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.pending
 
@@ -55,7 +82,9 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_cancelled_recurring_application_charge
-    fake("recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.cancelled
 
@@ -63,7 +92,9 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_accepted_recurring_application_charge
-    fake("recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.accepted
 
@@ -72,7 +103,9 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_declined_recurring_application_charge
-    fake("recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.declined
 
@@ -80,7 +113,9 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_activate_recurring_application_charge
-    fake("recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
     fake("recurring_application_charges/455696199/activate", method: :post, status: 200, body: "{}")
 
     charge = ShopifyAPI::RecurringApplicationCharge.accepted
@@ -89,8 +124,18 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_adjust_recurring_application_charge
-    fake("recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge'))
-    fake("recurring_application_charges/654381177/customize.json?recurring_application_charge%5Bcapped_amount%5D=200", method: :put, body: load_fixture('recurring_application_charge_adjustment'), extension: false)
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
+    fake(
+      "recurring_application_charges/654381177/customize.json?recurring_application_charge%5Bcapped_amount%5D=200",
+      method: :put,
+      body: load_fixture('recurring_application_charge_adjustment'),
+      extension: false
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
 
@@ -98,7 +143,9 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_cancel_recurring_application_charge
-    fake("recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges'))
+    fake(
+      "recurring_application_charges", method: :get, status: 201, body: load_fixture('recurring_application_charges')
+    )
     fake("recurring_application_charges/455696194", method: :delete, status: 200, body: "{}")
 
     charge = ShopifyAPI::RecurringApplicationCharge.current
@@ -106,8 +153,18 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_usage_charges_recurring_application_charge_found
-    fake("recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge'))
-    fake("recurring_application_charges/654381177/usage_charges", method: :get, status: 201, body: load_fixture('usage_charges'))
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
+    fake(
+      "recurring_application_charges/654381177/usage_charges",
+      method: :get,
+      status: 201,
+      body: load_fixture('usage_charges')
+    )
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)
     usage_charges = charge.usage_charges
@@ -116,7 +173,12 @@ class RecurringApplicationChargeTest < Test::Unit::TestCase
   end
 
   def test_usage_charges_recurring_application_charge_not_found
-    fake("recurring_application_charges/654381177", method: :get, status: 201, body: load_fixture('recurring_application_charge'))
+    fake(
+      "recurring_application_charges/654381177",
+      method: :get,
+      status: 201,
+      body: load_fixture('recurring_application_charge')
+    )
     fake("recurring_application_charges/654381177/usage_charges", method: :get, status: 201, body: "[]")
 
     charge = ShopifyAPI::RecurringApplicationCharge.find(654381177)

test/redirect_test.rb

@@ -2,8 +2,8 @@ require 'test_helper'
 
 class RedirectTest < Test::Unit::TestCase
   test "#create should create a redirect" do
-    fake "redirects", method: :post, status: 201, body: load_fixture('redirect')
+    fake("redirects", method: :post, status: 201, body: load_fixture('redirect'))
     redirect = ShopifyAPI::Redirect.create(path: "/ipod", target: "/pages/itunes")
-    assert_equal 979034150, redirect.id
+    assert_equal(979034150, redirect.id)
   end
 end

test/refund_test.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 class RefundTest < Test::Unit::TestCase
 
   test '#create should create a refund' do
-    fake "orders/450789469/refunds", method: :post, status: 201, body: load_fixture('refund')
+    fake("orders/450789469/refunds", method: :post, status: 201, body: load_fixture('refund'))
     refund = ShopifyAPI::Refund.create(
       order_id: 450789469,
       restock: true,
@@ -11,22 +11,27 @@ class RefundTest < Test::Unit::TestCase
       shipping: { full_refund: true },
       refund_line_items: [{ line_item_id: 518995019, quantity: 1 }]
     )
-    assert_equal 703073504, refund.refund_line_items.first.line_item_id
+    assert_equal(703073504, refund.refund_line_items.first.line_item_id)
   end
 
   test '#find should return a refund' do
-    fake "orders/450789469/refunds/509562969.json?order_id=450789469", extension: false, method: :get, body: load_fixture('refund')
-    fake "orders/450789469/refunds/509562969", method: :get, body: load_fixture('refund')
+    fake(
+      "orders/450789469/refunds/509562969.json?order_id=450789469",
+      extension: false,
+      method: :get,
+      body: load_fixture('refund')
+    )
+    fake("orders/450789469/refunds/509562969", method: :get, body: load_fixture('refund'))
     refund = ShopifyAPI::Refund.find(509562969, params: { order_id: 450789469 })
-    assert_equal 509562969, refund.id
+    assert_equal(509562969, refund.id)
   end
 
   test '#calculate a refund' do
-    fake "orders/450789469/refunds/calculate", method: :post, body: load_fixture('refund')
+    fake("orders/450789469/refunds/calculate", method: :post, body: load_fixture('refund'))
     data = { shipping: { amount: 0 } }
 
     refund = ShopifyAPI::Refund.calculate(data, params: { order_id: 450789469 })
-    assert_equal 2, refund.refund_line_items.count
-    assert_equal 703073504, refund.refund_line_items.first.line_item_id
+    assert_equal(2, refund.refund_line_items.count)
+    assert_equal(703073504, refund.refund_line_items.first.line_item_id)
   end
 end

test/report_test.rb

@@ -2,34 +2,35 @@ require 'test_helper'
 
 class ReportTest < Test::Unit::TestCase
   test 'get should get a report' do
-    fake 'reports/987', method: :get, status: 200, body: load_fixture('report')
+    fake('reports/987', method: :get, status: 200, body: load_fixture('report'))
 
     report = ShopifyAPI::Report.find(987)
-    assert_equal 987, report.id
+    assert_equal(987, report.id)
   end
 
   test 'get all should get all reports' do
-    fake 'reports', method: :get, status: 200, body: load_fixture('reports')
+    fake('reports', method: :get, status: 200, body: load_fixture('reports'))
 
     reports = ShopifyAPI::Report.all
-    assert_equal 'custom_app_reports', reports.first.category
+    assert_equal('custom_app_reports', reports.first.category)
   end
 
   test 'create should create a report' do
-    fake 'reports', method: :post, status: 201, body: load_fixture('report')
+    fake('reports', method: :post, status: 201, body: load_fixture('report'))
 
     report = ShopifyAPI::Report.create(
       name: 'Custom App Report',
-      shopify_ql: 'SHOW quantity_count, total_sales BY product_type, vendor, product_title FROM products SINCE -1m UNTIL -0m ORDER BY total_sales DESC'
+      shopify_ql: 'SHOW quantity_count, total_sales BY product_type, vendor, product_title ' \
+        'FROM products SINCE -1m UNTIL -0m ORDER BY total_sales DESC'
     )
-    assert_equal 'custom_app_reports', report.category
+    assert_equal('custom_app_reports', report.category)
   end
 
   test 'delete should delete report' do
-    fake 'reports/987', method: :get, status: 200, body: load_fixture('report')
-    fake 'reports/987', method: :delete, status: 200, body: '[]'
+    fake('reports/987', method: :get, status: 200, body: load_fixture('report'))
+    fake('reports/987', method: :delete, status: 200, body: '[]')
 
     report = ShopifyAPI::Report.find(987)
-    assert report.destroy
+    assert(report.destroy)
   end
 end

test/script_tag_test.rb

@@ -2,29 +2,29 @@ require 'test_helper'
 
 class ScriptTagTest < Test::Unit::TestCase
   test "get all should get all script tags" do
-    fake 'script_tags', method: :get, status: 200, body: load_fixture('script_tags')
+    fake('script_tags', method: :get, status: 200, body: load_fixture('script_tags'))
     script_tags = ShopifyAPI::ScriptTag.all
-    assert_equal "http://js-aplenty.com/bar.js", script_tags.first.src
+    assert_equal("http://js-aplenty.com/bar.js", script_tags.first.src)
   end
 
   test "get should get a script tag" do
-    fake 'script_tags/421379493', method: :get, status: 200, body: load_fixture('script_tag')
+    fake('script_tags/421379493', method: :get, status: 200, body: load_fixture('script_tag'))
     script_tag = ShopifyAPI::ScriptTag.find(421379493)
-    assert_equal "http://js-aplenty.com/bar.js", script_tag.src
+    assert_equal("http://js-aplenty.com/bar.js", script_tag.src)
   end
 
   test "create should create a new script tag" do
-    fake 'script_tags', method: :post, status: 201, body: load_fixture('script_tag')
+    fake('script_tags', method: :post, status: 201, body: load_fixture('script_tag'))
     script_tag = ShopifyAPI::ScriptTag.create(event: "onload", src: "http://js-aplenty.com/bar.js")
-    assert_equal "http://js-aplenty.com/bar.js", script_tag.src
+    assert_equal("http://js-aplenty.com/bar.js", script_tag.src)
   end
 
   test "editing script tag should update script tag" do
-    fake 'script_tags/421379493', method: :get, status: 200, body: load_fixture('script_tag')
+    fake('script_tags/421379493', method: :get, status: 200, body: load_fixture('script_tag'))
     script_tag = ShopifyAPI::ScriptTag.find(421379493)
     script_tag.src = "http://js-aplenty.com/bar.js"
-    fake 'script_tags/421379493', method: :put, status: 200, body: load_fixture('script_tag')
+    fake('script_tags/421379493', method: :put, status: 200, body: load_fixture('script_tag'))
     script_tag.save
-    assert_equal "http://js-aplenty.com/bar.js", script_tag.src
+    assert_equal("http://js-aplenty.com/bar.js", script_tag.src)
   end
 end

test/session_test.rb

@@ -10,33 +10,37 @@ class SessionTest < Test::Unit::TestCase
 
   test "not be valid without a url" do
     session = ShopifyAPI::Session.new(domain: nil, token: "any-token", api_version: any_api_version)
-    assert_not session.valid?
+    assert_not(session.valid?)
   end
 
   test "not be valid without token" do
     session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: any_api_version)
-    assert_not session.valid?
+    assert_not(session.valid?)
   end
 
   test "not be valid without an API version" do
     session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: "any-token", api_version: nil)
-    assert_not session.valid?
+    assert_not(session.valid?)
 
-    session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: "any-token", api_version: ShopifyAPI::ApiVersion::NullVersion)
-    assert_not session.valid?
+    session = ShopifyAPI::Session.new(
+      domain: "testshop.myshopify.com", token: "any-token", api_version: ShopifyAPI::ApiVersion::NullVersion
+    )
+    assert_not(session.valid?)
   end
 
   test "default to base API version" do
     session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: "any-token")
-    assert session.valid?
-    assert_equal session.api_version, ShopifyAPI::Base.api_version
+    assert(session.valid?)
+    assert_equal(session.api_version, ShopifyAPI::Base.api_version)
   end
 
   test "can override the base API version" do
     different_api_version = '2020-01'
-    session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: "any-token", api_version: different_api_version)
-    assert session.valid?
-    assert_equal session.api_version, ShopifyAPI::ApiVersion.find_version(different_api_version)
+    session = ShopifyAPI::Session.new(
+      domain: "testshop.myshopify.com", token: "any-token", api_version: different_api_version
+    )
+    assert(session.valid?)
+    assert_equal(session.api_version, ShopifyAPI::ApiVersion.find_version(different_api_version))
   end
 
   test "be valid with any token, any url and version" do
@@ -45,7 +49,7 @@ class SessionTest < Test::Unit::TestCase
       token: "any-token",
       api_version: any_api_version
     )
-    assert session.valid?
+    assert(session.valid?)
   end
 
   test "not raise error without params" do
@@ -87,8 +91,8 @@ class SessionTest < Test::Unit::TestCase
 
   test "setup api_key and secret for all sessions" do
     ShopifyAPI::Session.setup(api_key: "My test key", secret: "My test secret")
-    assert_equal "My test key", ShopifyAPI::Session.api_key
-    assert_equal "My test secret", ShopifyAPI::Session.secret
+    assert_equal("My test key", ShopifyAPI::Session.api_key)
+    assert_equal("My test secret", ShopifyAPI::Session.secret)
   end
 
   test "#temp reset ShopifyAPI::Base values to original value" do
@@ -168,7 +172,7 @@ class SessionTest < Test::Unit::TestCase
       api_version: :unstable
     )
 
-    assert_raises StandardError do
+    assert_raises(StandardError) do
       ShopifyAPI::Session.with_session(other_session) { raise StandardError, "" }
     end
 
@@ -214,7 +218,11 @@ class SessionTest < Test::Unit::TestCase
     )
     scope = ["write_products"]
     permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com")
-    assert_equal "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&scope=write_products&redirect_uri=http://my_redirect_uri.com", permission_url
+    assert_equal(
+      "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&" \
+        "scope=write_products&redirect_uri=http://my_redirect_uri.com",
+      permission_url
+    )
   end
 
   test "create_permission_url returns correct url with dual scope" do
@@ -226,7 +234,11 @@ class SessionTest < Test::Unit::TestCase
     )
     scope = ["write_products","write_customers"]
     permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com")
-    assert_equal "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&scope=write_products,write_customers&redirect_uri=http://my_redirect_uri.com", permission_url
+    assert_equal(
+      "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&" \
+        "scope=write_products,write_customers&redirect_uri=http://my_redirect_uri.com",
+      permission_url
+    )
   end
 
   test "create_permission_url returns correct url with no scope" do
@@ -238,7 +250,11 @@ class SessionTest < Test::Unit::TestCase
     )
     scope = []
     permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com")
-    assert_equal "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&scope=&redirect_uri=http://my_redirect_uri.com", permission_url
+    assert_equal(
+      "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&" \
+        "scope=&redirect_uri=http://my_redirect_uri.com",
+      permission_url
+    )
   end
 
   test "create_permission_url returns correct url with state" do
@@ -250,7 +266,11 @@ class SessionTest < Test::Unit::TestCase
     )
     scope = []
     permission_url = session.create_permission_url(scope, "http://my_redirect_uri.com", state: "My nonce")
-    assert_equal "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&scope=&redirect_uri=http://my_redirect_uri.com&state=My%20nonce", permission_url
+    assert_equal(
+      "https://localhost.myshopify.com/admin/oauth/authorize?client_id=My_test_key&" \
+        "scope=&redirect_uri=http://my_redirect_uri.com&state=My%20nonce",
+      permission_url
+    )
   end
 
   test "raise exception if code invalid in request token" do
@@ -270,7 +290,7 @@ class SessionTest < Test::Unit::TestCase
     assert_raises(ShopifyAPI::ValidationException) do
       session.request_token(code: "bad-code")
     end
-    assert_equal false, session.valid?
+    assert_equal(false, session.valid?)
   end
 
   test "return site for session" do
@@ -279,59 +299,65 @@ class SessionTest < Test::Unit::TestCase
       token: "any-token",
       api_version: any_api_version
     )
-    assert_equal "https://testshop.myshopify.com", session.site
+    assert_equal("https://testshop.myshopify.com", session.site)
   end
 
   test "return_token_if_signature_is_valid" do
     api_version = any_api_version
-    fake nil,
+    fake(
+      nil,
       url: "https://testshop.myshopify.com/admin/oauth/access_token",
       method: :post,
       body: '{"access_token":"any-token"}'
+    )
     session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: api_version)
 
     params = { code: 'any-code', timestamp: Time.now }
     token = session.request_token(params.merge(hmac: generate_signature(params)))
 
-    assert_equal "any-token", token
-    assert_equal "any-token", session.token
+    assert_equal("any-token", token)
+    assert_equal("any-token", session.token)
   end
 
   test "extra parameters are stored in session" do
     api_version = ShopifyAPI::ApiVersion.new(handle: :unstable)
-    fake nil,
+    fake(
+      nil,
       url: "https://testshop.myshopify.com/admin/oauth/access_token",
       method: :post,
       body: '{"access_token":"any-token","foo":"example"}'
+    )
     session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: api_version)
 
     params = { code: 'any-code', timestamp: Time.now }
-    assert session.request_token(params.merge(hmac: generate_signature(params)))
+    assert(session.request_token(params.merge(hmac: generate_signature(params))))
 
-    assert_equal ({ "foo" => "example" }), session.extra
+    assert_equal(({ "foo" => "example" }), session.extra)
   end
 
   test "expires_in is automatically converted in expires_at" do
     api_version = any_api_version
-    fake nil,
+    fake(
+      nil,
       url: "https://testshop.myshopify.com/admin/oauth/access_token",
       method: :post,
       body: '{"access_token":"any-token","expires_in":86393}'
+    )
     session = ShopifyAPI::Session.new(domain: "testshop.myshopify.com", token: nil, api_version: api_version)
 
     Timecop.freeze do
       params = { code: 'any-code', timestamp: Time.now }
-      assert session.request_token(params.merge(hmac: generate_signature(params)))
+      assert(session.request_token(params.merge(hmac: generate_signature(params))))
 
       expires_at = Time.now.utc + 86393
-      assert_equal ({ "expires_at" => expires_at.to_i }), session.extra
-      assert session.expires_at.is_a?(Time)
-      assert_equal expires_at.to_i, session.expires_at.to_i
-      assert_equal 86393, session.expires_in
-      assert_equal false, session.expired?
+      assert_equal(({ "expires_at" => expires_at.to_i }), session.extra)
+      assert(session.expires_at.is_a?(Time))
+      assert_equal(expires_at.to_i, session.expires_at.to_i)
+      assert_equal(86393, session.expires_in)
+      assert_equal(false, session.expired?)
 
       Timecop.travel(session.expires_at) do
-        assert_equal true, session.expired?
+        assert_equal(true, session.expired?)
       end
     end
   end
@@ -359,7 +385,7 @@ class SessionTest < Test::Unit::TestCase
   test "return true when the signature is valid and the keys of params are strings" do
     params = { 'code' => 'any-code', 'timestamp' => Time.now }
     params[:hmac] = generate_signature(params)
-    assert_equal true, ShopifyAPI::Session.validate_signature(params)
+    assert_equal(true, ShopifyAPI::Session.validate_signature(params))
   end
 
   test "return true when validating signature of params with ampersand and equal sign characters" do
@@ -367,7 +393,7 @@ class SessionTest < Test::Unit::TestCase
     params = { 'a' => '1&b=2', 'c=3&d' => '4' }
     to_sign = 'a=1%26b=2&c%3D3%26d=4'
     params[:hmac] = generate_signature(to_sign)
-    assert_equal true, ShopifyAPI::Session.validate_signature(params)
+    assert_equal(true, ShopifyAPI::Session.validate_signature(params))
   end
 
   test "return true when validating signature of params with percent sign characters" do
@@ -375,7 +401,7 @@ class SessionTest < Test::Unit::TestCase
     params = { 'a%3D1%26b' => '2%26c%3D3' }
     to_sign = 'a%253D1%2526b=2%2526c%253D3'
     params[:hmac] = generate_signature(to_sign)
-    assert_equal true, ShopifyAPI::Session.validate_signature(params)
+    assert_equal(true, ShopifyAPI::Session.validate_signature(params))
   end
 
   test "url is aliased to domain to minimize the upgrade changes" do

test/shipping_zone_test.rb

@@ -2,9 +2,9 @@ require 'test_helper'
 
 class ShippingZoneTest < Test::Unit::TestCase
   test "get all should get all shipping zones" do
-    fake 'shipping_zones', method: :get, status: 200, body: load_fixture('shipping_zones')
+    fake('shipping_zones', method: :get, status: 200, body: load_fixture('shipping_zones'))
     checkout = ShopifyAPI::ShippingZone.all
-    assert_equal 1, checkout.first.id
-    assert_equal "Canada", checkout.first.name
+    assert_equal(1, checkout.first.id)
+    assert_equal("Canada", checkout.first.name)
   end
 end

test/shop_test.rb

@@ -17,7 +17,13 @@ class ShopTest < Test::Unit::TestCase
   end
 
   def test_current_with_options_should_return_current_shop
-    fake("shop.json?fields%5B%5D=name&fields%5B%5D=myshopify_domain", extension: false, method: :get, status: 201, body: load_fixture('shop'))
+    fake(
+      "shop.json?fields%5B%5D=name&fields%5B%5D=myshopify_domain",
+      extension: false,
+      method: :get,
+      status: 201,
+      body: load_fixture('shop')
+    )
 
     @shop = ShopifyAPI::Shop.current(params: { fields: [:name, :myshopify_domain] })
     assert(@shop.is_a?(ShopifyAPI::Shop))
@@ -49,8 +55,15 @@ class ShopTest < Test::Unit::TestCase
   def test_add_metafield
     fake("metafields", method: :post, status: 201, body: load_fixture('metafield'))
 
-    field = @shop.add_metafield(ShopifyAPI::Metafield.new(namespace: "contact", key: "email", value: "123@example.com", value_type: "string"))
-    assert_equal(ActiveSupport::JSON.decode('{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'), ActiveSupport::JSON.decode(WebMock.last_request.body))
+    field = @shop.add_metafield(
+      ShopifyAPI::Metafield.new(namespace: "contact", key: "email", value: "123@example.com", value_type: "string")
+    )
+    assert_equal(
+      ActiveSupport::JSON.decode(
+        '{"metafield":{"namespace":"contact","key":"email","value":"123@example.com","value_type":"string"}}'
+      ),
+      ActiveSupport::JSON.decode(WebMock.last_request.body)
+    )
     assert(!field.new_record?)
     assert_equal("contact", field.namespace)
     assert_equal("email", field.key)

test/smart_collection_test.rb

@@ -2,9 +2,9 @@ require 'test_helper'
 
 class SmartCollectionTest < Test::Unit::TestCase
   test "Smart Collection creation" do
-    fake "smart_collections", method: :post, status: 201, body: load_fixture('smart_collection')
+    fake("smart_collections", method: :post, status: 201, body: load_fixture('smart_collection'))
     rules = { column: "title", relation: "starts_with", condition: "mac" }
     smart_collection = ShopifyAPI::SmartCollection.create(title: "Macbooks", rules: rules)
-    assert_equal 1063001432, smart_collection.id
+    assert_equal(1063001432, smart_collection.id)
   end
 end

test/storefront_access_token_test.rb

@@ -12,7 +12,6 @@ class StorefrontAccessTokenTest < Test::Unit::TestCase
   def test_delete_storefront_access_token
     fake('storefront_access_tokens/1', method: :get, status: 200, body: load_fixture('storefront_access_token'))
     fake('storefront_access_tokens/1', method: :delete, status: 200, body: 'destroyed')
-    
     storefront_access_tokens = ShopifyAPI::StorefrontAccessToken.find(1)
     assert(storefront_access_tokens.destroy)
   end

test/tax_service_test.rb

@@ -1,9 +1,12 @@
 require 'test_helper'
 class TaxServiceTest < Test::Unit::TestCase
   test "tax service creation" do
-    fake "tax_services", method: :post, status: 202, body: load_fixture('tax_service')
+    fake("tax_services", method: :post, status: 202, body: load_fixture('tax_service'))
     ShopifyAPI::TaxService.create(name: "My Tax Service", url: "https://mytaxservice.com")
-    assert_equal '{"tax_service":{"name":"My Tax Service","url":"https://mytaxservice.com"}}', WebMock.last_request.body
+    assert_equal(
+      '{"tax_service":{"name":"My Tax Service","url":"https://mytaxservice.com"}}',
+      WebMock.last_request.body
+    )
 
   end
 end

test/tender_transaction_test.rb

@@ -11,8 +11,8 @@ class TenderTransactionTest < Test::Unit::TestCase
   context "Tender Transaction" do
     should 'return a list of transactions' do
       tender_transactions = ShopifyAPI::TenderTransaction.all
-      assert_equal 3, tender_transactions.length
-      assert_equal [1, 2, 3], tender_transactions.map(&:id)
+      assert_equal(3, tender_transactions.length)
+      assert_equal([1, 2, 3], tender_transactions.map(&:id))
     end
   end
 end

test/transaction_test.rb

@@ -10,7 +10,7 @@ class TransactionTest < Test::Unit::TestCase
     context "#find" do
       should "find a specific transaction" do
         transaction = ShopifyAPI::Transaction.find(389404469, params: { order_id: 450789469 })
-        assert_equal "409.94", transaction.amount
+        assert_equal("409.94", transaction.amount)
       end
     end
   end

test/usage_charge_test.rb

@@ -11,7 +11,12 @@ class UsageChargeTest < Test::Unit::TestCase
   end
 
   def test_get_usage_charges
-    fake("recurring_application_charges/654381177/usage_charges/359376002", method: :get, status: 201, body: load_fixture('usage_charge'))
+    fake(
+      "recurring_application_charges/654381177/usage_charges/359376002",
+      method: :get,
+      status: 201,
+      body: load_fixture('usage_charge')
+    )
 
     usage_charge = ShopifyAPI::UsageCharge.find(359376002, params: { recurring_application_charge_id: 654381177 })
 

test/variant_test.rb

@@ -108,7 +108,9 @@ class VariantTest < Test::Unit::TestCase
   private
 
   def refresh_variant(api_version: nil)
-    fake("products/632910392/variants/808950810", method: :get, body: load_fixture('variant'), api_version: api_version)
+    fake(
+      "products/632910392/variants/808950810", method: :get, body: load_fixture('variant'), api_version: api_version
+    )
     @variant = ShopifyAPI::Variant.find(808950810, params: { product_id: 632910392 })
   end
 end

test/webhook_test.rb

@@ -2,20 +2,22 @@ require 'test_helper'
 
 class WebhookTest < Test::Unit::TestCase
   test 'create should create a webhook' do
-    fake 'webhooks', method: :post, status: 201, body: load_fixture('webhook')
-    webhook = ShopifyAPI::Webhook.create(address: "http://www.yoloship.it/webhook", topic: "orders/create", format: "json")
-    assert_equal "http://www.yoloship.it/webhook", webhook.address
+    fake('webhooks', method: :post, status: 201, body: load_fixture('webhook'))
+    webhook = ShopifyAPI::Webhook.create(
+      address: "http://www.yoloship.it/webhook", topic: "orders/create", format: "json"
+    )
+    assert_equal("http://www.yoloship.it/webhook", webhook.address)
   end
 
   test 'get should retrieve a webhook' do
-    fake 'webhooks/123456', method: :get, status: 200, body: load_fixture('webhook')
+    fake('webhooks/123456', method: :get, status: 200, body: load_fixture('webhook'))
     webhook = ShopifyAPI::Webhook.find(123456)
-    assert_equal "http://www.yoloship.it/webhook", webhook.address
+    assert_equal("http://www.yoloship.it/webhook", webhook.address)
   end
 
   test 'find all should return all webhooks' do
-    fake 'webhooks', method: :get, status: 200, body: load_fixture('webhooks')
+    fake('webhooks', method: :get, status: 200, body: load_fixture('webhooks'))
     webhook = ShopifyAPI::Webhook.all
-    assert_equal 123456, webhook.first.id
+    assert_equal(123456, webhook.first.id)
   end
 end